Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can only be installed as superuser #15

Closed
maparent opened this issue Jul 6, 2021 · 6 comments
Closed

can only be installed as superuser #15

maparent opened this issue Jul 6, 2021 · 6 comments

Comments

@maparent
Copy link
Collaborator

maparent commented Jul 6, 2021

The database owner cannot now install the extension ("must be superuser" error message.)
There is nothing that requires this, and it's as simple as adding superuser=false to pgjwt.control.

@steve-chavez
Copy link

IIRC, pgcrypto requires superuser and that's listed as a dependency on pgjwt.control.

@maparent
Copy link
Collaborator Author

pgcrypto is a trusted module and does not require superuser permissions to install. It would be nice if pgjwt did not add a new constraint.

@steve-chavez
Copy link

steve-chavez commented Oct 13, 2021

pgcrypto is a trusted module

Ah, seems that changed since pg 13, pg 12 and below still require superuser for pgcrypto.

https://www.postgresql.org/docs/12/pgcrypto.html

@maparent
Copy link
Collaborator Author

Ah, fair point! Sorry I missed that. But I think the point stands; even if a superuser had to install pgcrypto, pyjwt does not escalate the pgcrypto permissions.

@michelp
Copy link
Owner

michelp commented Oct 13, 2021

Sorry for the delay on getting back to you, I've been under a pile of other work and pgjwt languished as a result. @maparent I've sent you an invitation to collaborate on this repo, if you accept feel free to merge both your pull requests if you feel they are the best solution going forward.

@maparent
Copy link
Collaborator Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants