Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve select box UX #179

Open
michalmikolajczyk opened this issue Jul 28, 2017 · 5 comments
Open

improve select box UX #179

michalmikolajczyk opened this issue Jul 28, 2017 · 5 comments
Assignees

Comments

@michalmikolajczyk
Copy link
Owner

as a user on a mobile device,
when I touch the language selectbox
and I don't make a choice,
but instead I touch elsewhere, outside from the expanded select list,
then the select box should simply close, as if cancelled

as a user on a mobile device,
when I open up the main menu and
when I interact with the language or currency selectbox,
then that interactions should not close the main menu

@michalmikolajczyk
Copy link
Owner Author

two problems here:

  1. changing language causes a top-to-bottom forced update of the app. It's not a reload, but a rerender. We would either need to use another i18n package, or make exceptions. Not worth the time, as the current solution is quite robust
  2. opening up multiple submenus is a big concer with material-ui and there are several underlying problems: [ListItem][IconMenu] Multiple IconMenu's can be opened at once mui/material-ui#6664 [DropDownMenu, SelectField] Unable to put nested Menus inside of a DropDownMenu mui/material-ui#4887 [IconMenu] Doesn't close on click-away in table cell. mui/material-ui#3047 The best way to do it, is to go with material ui 1 beta. I commenced work on that here: https://github.com/michalmikolajczyk/viking-garage-frontend/tree/icon-menu-material-ui-next but we would need to rewrite multiple parts of the app to be compatible with material-ui 1.

In other words: bail

@michalmikolajczyk
Copy link
Owner Author

michalmikolajczyk commented Aug 19, 2017

update:

  1. corrected by upgrading to 0.19
  2. slightly improved by moving the submenu a bit to the right. The underlying issue is still a problem, requested help here [IconMenu][MenuItem] multiple submenus open and overlapping mui/material-ui#7841

@lam3lka lam3lka changed the title improve select box UX on mobile improve select box UX Aug 19, 2017
@lam3lka
Copy link
Collaborator

lam3lka commented Aug 19, 2017

  • improve select box UX on mobile

  • improve select box UX on desktop

@lam3lka
Copy link
Collaborator

lam3lka commented Aug 19, 2017

As a desktop user
when I touch the language selectbox or currency selectbox
and I want to choose another selectbox
the previous one should close automatically
So we do not have situation that there are two opened selectboxes.

zrzut ekranu 2017-08-19 o 18 30 23

@michalmikolajczyk
Copy link
Owner Author

@lam3lka the desktop requested functionality is already in place. After reading the response to my support request ticket, I decided to postpone enhancing the mobile version, till material-ui v.1 is released (which will happen soon). It is so much better, you will love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants