Add Client#list_users_without_permissions

while at it, fix a bug where it wasn't possible
to give StatusCode::NOT_FOUND a pass when
assessing whether to return an error..

Author: michaelklishin

src/blocking_api.rs

@@ -240,6 +240,14 @@ where
         Ok(response)
     }
 
+    /// Lists users in the internal database that do not have access
+    /// to any virtual hosts.
+    pub fn list_users_without_permissions(&self) -> Result<Vec<responses::User>> {
+        let response = self.http_get("users/without-permissions", None, None)?;
+        let response = response.json()?;
+        Ok(response)
+    }
+
     /// Lists all client connections across the cluster.
     pub fn list_connections(&self) -> Result<Vec<responses::Connection>> {
         let response = self.http_get("connections", None, None)?;
@@ -1169,8 +1177,14 @@ where
         server_code_to_accept_or_ignore: Option<StatusCode>,
     ) -> Result<HttpClientResponse> {
         let status = response.status();
-        if status == StatusCode::NOT_FOUND {
-            return Err(NotFound);
+
+        match client_code_to_accept_or_ignore {
+            Some(status_code) if status_code == StatusCode::NOT_FOUND => {}
+            _ => {
+                if status == StatusCode::NOT_FOUND {
+                    return Err(NotFound);
+                }
+            }
         }
 
         if status.is_client_error() {

tests/user_tests.rs

@@ -27,6 +27,37 @@ fn test_list_users() {
     assert!(vec.iter().any(|u| u.name == "guest"))
 }
 
+#[test]
+fn test_list_users_without_permissions() {
+    let endpoint = endpoint();
+    let rc = Client::new(&endpoint, USERNAME, PASSWORD);
+    let test_name = "test_list_users_without_permissions";
+
+    let username = format!("{}.1", test_name);
+    rc.delete_user(&username, true)
+        .expect("failed to delete a user");
+
+    let salt = password_hashing::salt();
+    let password_hash = password_hashing::base64_encoded_salted_password_hash_sha256(
+        &salt,
+        "test_list_users_without_permissions.1",
+    );
+    let params = UserParams {
+        name: &username,
+        password_hash: &password_hash,
+        tags: "",
+    };
+    rc.create_user(&params).expect("failed to create a user");
+
+    let result1 = rc.list_users_without_permissions();
+    assert!(result1.is_ok());
+    let vec = result1.unwrap();
+    assert!(vec.iter().any(|u| u.name == username));
+
+    rc.delete_user(&username, true)
+        .expect("failed to delete a user");
+}
+
 #[test]
 fn test_get_user() {
     let endpoint = endpoint();