Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide TypeScript Definition #64

Open
iddan opened this issue May 17, 2022 · 2 comments · May be fixed by #70
Open

Provide TypeScript Definition #64

iddan opened this issue May 17, 2022 · 2 comments · May be fixed by #70

Comments

@iddan
Copy link

iddan commented May 17, 2022

Hey, thank you for creating this great package.
It would be really nice if it could be shipped with TypeScript definitions for the TypeScript folks in the crowd.
@mheap
Copy link
Owner

mheap commented Jun 21, 2022

Hey @iddan,

This is a great suggestion, but not one that I know where to start. Would you be open to submitting a PR to add types?

@iddan iddan linked a pull request Jun 21, 2022 that will close this issue
Open
@iddan
Copy link
Author

iddan commented Jun 21, 2022

Hey @mheap, I created a pull request with the types definition I'm using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TypeScript definitions iddan/octokit-commit-multiple-files
2 participants
@mheap @iddan