close connection in case of DatabaseError #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😱, that was quick. Thanks, I'll take a look |
mgckind
reviewed
Apr 26, 2019
| print(colored('Your query raised DatabaseError:', "red", self.ct)) | ||
| print(colored(str(exc), "red", self.ct)) | ||
| self.con.close() | ||
| if self.loading_bar: |
There was a problem hiding this comment.
I think I have it somewhere, but is the connection reopen after closing it?
There was a problem hiding this comment.
As far as I checked the next step after closing/canceling connection is pinging the database to check the connection. If the ping comes back as False, the code will connect to database again. Try to run invalid query and then a valid one.
There was a problem hiding this comment.
oh i see, yes, that's what i meant. great!
mgckind
approved these changes
Apr 26, 2019
| (type, value, traceback) = sys.exc_info() | ||
| self.con.cancel() | ||
| t2 = time.time() | ||
|
|
||
| (type, value, traceback) = sys.exc_info() | ||
| self.con.cancel() |
There was a problem hiding this comment.
aren't these lines duplicated? they don't show are being removed
| print(colored('Your query raised DatabaseError:', "red", self.ct)) | ||
| print(colored(str(exc), "red", self.ct)) | ||
| self.con.close() | ||
| if self.loading_bar: |
There was a problem hiding this comment.
oh i see, yes, that's what i meant. great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130
@mgckind PTAL
Code catches the cx_Oracle.Database error due to incorrect syntax in query and closes the connection instead of trying to cancel it.
Cancelling connection causes it to hang, closing it allows to go around it.