[FEAT] Verify shipping charge upto 4 decimal places (django-oscar#370)

* feat ⭐ verify shipping charge upto 4 decimal places

Author: samar-hassan

oscarapi/basket/operations.py

@@ -1,4 +1,5 @@
 "This module contains operation on baskets and lines"
+
 from django.conf import settings
 
 from oscar.core.loading import get_class, get_model

oscarapi/serializers/checkout.py

@@ -49,12 +49,12 @@ class PriceSerializer(serializers.Serializer):
     currency = serializers.CharField(
         max_length=12, default=django_settings.OSCAR_DEFAULT_CURRENCY, required=False
     )
-    excl_tax = serializers.DecimalField(decimal_places=2, max_digits=12, required=True)
+    excl_tax = serializers.DecimalField(decimal_places=4, max_digits=12, required=True)
     incl_tax = TaxIncludedDecimalField(
-        excl_tax_field="excl_tax", decimal_places=2, max_digits=12, required=False
+        excl_tax_field="excl_tax", decimal_places=4, max_digits=12, required=False
     )
     tax = TaxIncludedDecimalField(
-        excl_tax_value="0.00", decimal_places=2, max_digits=12, required=False
+        excl_tax_value="0.00", decimal_places=4, max_digits=12, required=False
     )
 
 

oscarapi/serializers/product.py

@@ -440,6 +440,7 @@ class Meta:
 
 class BaseProductSerializer(OscarModelSerializer):
     "Base class shared by admin and public serializer"
+
     attributes = ProductAttributeValueSerializer(
         many=True, required=False, source="attribute_values"
     )
@@ -476,6 +477,7 @@ class Meta:
 
 class PublicProductSerializer(BaseProductSerializer):
     "Serializer base class used for public products api"
+
     url = serializers.HyperlinkedIdentityField(view_name="product-detail")
     price = serializers.HyperlinkedIdentityField(
         view_name="product-price", read_only=True
@@ -494,6 +496,7 @@ def get_field_names(self, declared_fields, info):
 
 class ChildProductSerializer(PublicProductSerializer):
     "Serializer for child products"
+
     parent = serializers.HyperlinkedRelatedField(
         view_name="product-detail",
         queryset=Product.objects.filter(structure=Product.PARENT),
@@ -508,6 +511,7 @@ class Meta(PublicProductSerializer.Meta):
 
 class ProductSerializer(PublicProductSerializer):
     "Serializer for public api with strategy fields added for price and availability"
+
     url = serializers.HyperlinkedIdentityField(view_name="product-detail")
     price = serializers.HyperlinkedIdentityField(
         view_name="product-price", read_only=True

oscarapi/tests/unit/testcheckout.py

@@ -490,9 +490,9 @@ def test_shipping_methods(self):
                 "discount": 0,
                 "price": {
                     "currency": None,
-                    "excl_tax": "0.00",
-                    "incl_tax": "0.00",
-                    "tax": "0.00",
+                    "excl_tax": "0.0000",
+                    "incl_tax": "0.0000",
+                    "tax": "0.0000",
                 },
             },
         )
@@ -516,9 +516,9 @@ def test_shipping_methods(self):
                 "discount": 0,
                 "price": {
                     "currency": "EUR",
-                    "excl_tax": "0.00",
-                    "incl_tax": "0.00",
-                    "tax": "0.00",
+                    "excl_tax": "0.0000",
+                    "incl_tax": "0.0000",
+                    "tax": "0.0000",
                 },
             },
         )