From e86da43af4aab0806051b2acbbc72f8b92465b06 Mon Sep 17 00:00:00 2001 From: Aviram Hassan Date: Tue, 28 Jan 2025 22:42:14 +0200 Subject: [PATCH] don't report error on notimplemented, might fix go crash (#3045) --- changelog.d/3044.fixed.md | 1 + mirrord/layer/src/error.rs | 4 ++++ 2 files changed, 5 insertions(+) create mode 100644 changelog.d/3044.fixed.md diff --git a/changelog.d/3044.fixed.md b/changelog.d/3044.fixed.md new file mode 100644 index 00000000000..c8c1e9d0f34 --- /dev/null +++ b/changelog.d/3044.fixed.md @@ -0,0 +1 @@ +don't report error on notimplemented, might fix go crash diff --git a/mirrord/layer/src/error.rs b/mirrord/layer/src/error.rs index da4797a1916..771f198944c 100644 --- a/mirrord/layer/src/error.rs +++ b/mirrord/layer/src/error.rs @@ -221,6 +221,10 @@ impl From for i64 { HookError::SocketUnsuportedIpv6 => { info!("{fail}") } + HookError::ResponseError(ResponseError::NotImplemented) => { + // this means we bypass, so we can just return to avoid setting libc. + return -1; + } HookError::ProxyError(ref err) => { graceful_exit!( r"Proxy error, connectivity issue or a bug.