From 983704779ef648f5cd7f7d90d2e11402fdad2d80 Mon Sep 17 00:00:00 2001
From: Vibhav Bobade <vibhav.bobde@gmail.com>
Date: Wed, 27 Nov 2024 15:32:25 +0530
Subject: [PATCH] feat: use default config path when no arg for -f is provided

---
 changelog.d/1706.changed.md |  1 +
 mirrord/cli/src/config.rs   | 12 ++++++------
 2 files changed, 7 insertions(+), 6 deletions(-)
 create mode 100644 changelog.d/1706.changed.md

diff --git a/changelog.d/1706.changed.md b/changelog.d/1706.changed.md
new file mode 100644
index 00000000000..4bfd36a59fe
--- /dev/null
+++ b/changelog.d/1706.changed.md
@@ -0,0 +1 @@
+add default value './mirrord.json' for the `--config-file` flag.
\ No newline at end of file
diff --git a/mirrord/cli/src/config.rs b/mirrord/cli/src/config.rs
index 96548235ad4..7ea36c4f180 100644
--- a/mirrord/cli/src/config.rs
+++ b/mirrord/cli/src/config.rs
@@ -204,7 +204,7 @@ pub(super) struct ExecParams {
     pub disable_version_check: bool,
 
     /// Load config from config file
-    #[arg(short = 'f', long, value_hint = ValueHint::FilePath)]
+    #[arg(short = 'f', long, value_hint = ValueHint::FilePath, default_value = "./mirrord.json")]
     pub config_file: Option<PathBuf>,
 
     /// Kube context to use from Kubeconfig
@@ -426,7 +426,7 @@ pub(super) struct PortForwardArgs {
     pub disable_version_check: bool,
 
     /// Load config from config file
-    #[arg(short = 'f', long, value_hint = ValueHint::FilePath)]
+    #[arg(short = 'f', long, value_hint = ValueHint::FilePath, default_value = "./mirrord.json")]
     pub config_file: Option<PathBuf>,
 
     /// Kube context to use from Kubeconfig
@@ -587,7 +587,7 @@ pub(super) enum OperatorCommand {
     /// Print operator status
     Status {
         /// Specify config file to use
-        #[arg(short = 'f', long, value_hint = ValueHint::FilePath)]
+        #[arg(short = 'f', long, value_hint = ValueHint::FilePath, default_value = "./mirrord.json")]
         config_file: Option<PathBuf>,
     },
     /// Operator session management commands.
@@ -727,7 +727,7 @@ impl ListTargetArgs {
 #[derive(Args, Debug)]
 pub(super) struct ExtensionExecArgs {
     /// Specify config file to use
-    #[arg(short = 'f', long, value_hint = ValueHint::FilePath)]
+    #[arg(short = 'f', long, value_hint = ValueHint::FilePath, default_value = "./mirrord.json")]
     pub config_file: Option<PathBuf>,
     /// Specify target
     #[arg(short = 't')]
@@ -766,7 +766,7 @@ pub(super) enum DiagnoseCommand {
     /// Check network connectivity and provide RTT (latency) statistics.
     Latency {
         /// Specify config file to use
-        #[arg(short = 'f', long, value_hint = ValueHint::FilePath)]
+        #[arg(short = 'f', long, value_hint = ValueHint::FilePath, default_value = "./mirrord.json")]
         config_file: Option<PathBuf>,
     },
 }
@@ -895,7 +895,7 @@ pub(super) struct VpnArgs {
     pub namespace: Option<String>,
 
     /// Load config from config file
-    #[arg(short = 'f', long, value_hint = ValueHint::FilePath)]
+    #[arg(short = 'f', long, value_hint = ValueHint::FilePath, default_value = "./mirrord.json")]
     pub config_file: Option<PathBuf>,
 
     #[cfg(target_os = "macos")]