From 05792a70055b46b7e87d4c2c1f91054fde37800c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Smolarek?= <34063647+Razz4780@users.noreply.github.com> Date: Thu, 23 Jan 2025 15:35:12 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: t4lz --- mirrord/config/src/target.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mirrord/config/src/target.rs b/mirrord/config/src/target.rs index 74cb67db8bd..d62e0ae1053 100644 --- a/mirrord/config/src/target.rs +++ b/mirrord/config/src/target.rs @@ -95,7 +95,7 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche /// ``` /// /// The setup above will result in a session targeting the `bear-pod` Kubernetes pod -/// in the user's default namespace. Target container will be chosen by mirrord. +/// in the user's default namespace. A target container will be chosen by mirrord. /// /// Shortened setup with target container: /// @@ -105,7 +105,7 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche /// } /// ``` /// -/// Setup above will result in a session targeting the `bear-pod-container` container +/// The setup above will result in a session targeting the `bear-pod-container` container /// in the `bear-pod` Kubernetes pod in the user's default namespace. /// /// Complete setup: @@ -122,7 +122,7 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche /// } /// ``` /// -/// Setup above will result in a session targeting the `bear-pod-container` container +/// The setup above will result in a session targeting the `bear-pod-container` container /// in the `bear-pod` Kubernetes pod in the `bear-pod-namespace` namespace. #[derive(Serialize, Deserialize, Clone, Eq, PartialEq, Hash, Debug)] #[serde(deny_unknown_fields)] @@ -154,7 +154,7 @@ pub struct TargetConfig { /// /// Namespace where the target lives. /// - /// Defaults to Kubernetes user's default namespace (defined in Kubernetes context). + /// Defaults to the Kubernetes user's default namespace (defined in Kubernetes context). #[serde(skip_serializing_if = "Option::is_none")] pub namespace: Option, } @@ -259,7 +259,7 @@ pub enum Target { Pod(pod::PodTarget), /// - /// [Rollout](https://argoproj.github.io/argo-rollouts/#how-does-it-work). + /// [Argo Rollout](https://argoproj.github.io/argo-rollouts/#how-does-it-work). Rollout(rollout::RolloutTarget), ///