.

Author: infiniteregrets

src/binaryManager.ts

@@ -82,7 +82,7 @@ async function getConfiguredMirrordBinary(): Promise<string | null> {
 
     let latestVersion;
     try {
-        latestVersion = await getLatestSupportedVersion(1000);
+        latestVersion = await getLatestSupportedVersion();
     } catch (err) {
         new NotificationBuilder()
             .withMessage(`failed to check latest supported version of mirrord binary, binary specified in settings may be outdated: ${err}`)
@@ -112,15 +112,15 @@ async function getConfiguredMirrordBinary(): Promise<string | null> {
  * to mirrord binary auto-update will prompt the user to reload the window.
  * @returns Path to mirrord binary
 */
-export async function getMirrordBinary(extensionActivate?: boolean): Promise<string> {
+export async function getMirrordBinary(): Promise<string> {
     const configured = await getConfiguredMirrordBinary();
 
     if (configured) {
         vscode.window.showInformationMessage(`Using mirrord binary specified in settings: ${configured}`);
         return configured;
     }
 
-    let foundLocal = await getLocalMirrordBinary();    
+    let foundLocal = await getLocalMirrordBinary();
     const latestVersion = await getLatestSupportedVersion();
 
     const autoUpdateConfigured = vscode.workspace.getConfiguration().get("mirrord.autoUpdate");
@@ -139,24 +139,6 @@ export async function getMirrordBinary(extensionActivate?: boolean): Promise<str
         return extensionPath;
     }
 
-
-    // if extension is activating, then set a global state to what was read in the workspace settings
-    if (extensionActivate) {
-        globalContext.workspaceState.update('autoUpdate', autoUpdateConfigured);
-    } else {
-        // extension is active, check if auto-update setting has changed
-        const autoUpdate = globalContext.workspaceState.get('autoUpdate');
-        if (autoUpdate !== autoUpdateConfigured) {
-            await new NotificationBuilder()
-                .withMessage("mirrord binary auto-update setting has changed, please reload the window for the change to take effect.")
-                .withGenericAction("Reload", async () => {
-                    await vscode.commands.executeCommand("workbench.action.reloadWindow");
-                })
-                .warning();
-            return extensionPath;
-        }        
-    }
-
     if (typeof autoUpdateConfigured === 'string') {
         if (semver.valid(autoUpdateConfigured)) {
             const localMirrordBinary = await getLocalMirrordBinary(autoUpdateConfigured);

src/extension.ts

@@ -14,7 +14,7 @@ export async function activate(context: vscode.ExtensionContext) {
 	vscode.debug.registerDebugConfigurationProvider('*', new ConfigurationProvider(), 2);
 
 	// start mirrord binary updates, so that we avoid downloading mid session
-	await getMirrordBinary(true);
+	await getMirrordBinary();
 
 	new MirrordStatus(vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 0))
 		.register()