Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_env not working in a run configuration #195

Closed
Idane opened this issue Nov 13, 2023 · 3 comments
Closed

get_env not working in a run configuration #195

Idane opened this issue Nov 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Idane
Copy link

Idane commented Nov 13, 2023

Bug Description

A specified environment variable in a run configuration in IntelliJ (Specifically tested Java and Spring Boot) does not get propagated to get_env

Steps to Reproduce

Using the following mirrord configuration:

{
  "target": "deploy/{{ get_env(name="DEPLOYMENT_NAME", default="na") }}",
  "feature": {
    "env": true,
    "fs": "read",
    "network": true
  }
}

Create a run configuration on IntelliJ and set your variable under environment variables;
image

Run the configuration with mirrord, the following error pops up indicating the default value was taken:

Create agent failed. KubeError( Api( ErrorResponse { status: "Failure", message: "deployments.apps \"na\" not found", reason: "NotFound", code: 404, }, ), )

Backtrace

No response

Relevant Logs

No response

Your operating system and version

Mac OS 13.4.1

Local process

java

Local process version

17

Additional Info

No response

@Idane Idane added the bug Something isn't working label Nov 13, 2023
@aviramha
Copy link
Member

I think this should be solved by #181

@eyalb181
Copy link
Member

Hey @Idane , we just released version 3.56.1 of our IntelliJ plugin which includes the change @aviramha mentioned above. Could you retest with this version?

@Idane
Copy link
Author

Idane commented Nov 30, 2023

Works now @eyalb181 @aviramha
Thanks!

@Idane Idane closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants