fix showing Catalyst error pages on missing source files

Show now the not found page rather than an internal error page if a
source file is not found.  We could throw to an internal error page on
500 errors, but that seems excessive, and 404 will be accurate for some
of those cases anyway.

Checking the code is necessary because some url forms will generate
internal errors from the back end, which won't be able to be decoded,
resulting in errors and warning.  One example of this is
/source/<%meta.name%>/<%meta.other%>

Author: haarg

lib/MetaCPAN/Web/Controller/Source.pm

@@ -26,8 +26,10 @@ sub index : Path : Args {
             $c->model('API::Module')->get(@module),
         );
     }
-    die "Bad module supplied\n"
+
+    $c->detach('/not_found')
         if grep +( $_->{code} || 0 ) > 399, $source, $module;
+
     if ( $module->{directory} ) {
         my $files = $c->model('API::File')->dir(@module)->get;
 

log4perl_prod.conf

@@ -1,7 +1,7 @@
 log4perl.rootLogger=WARN, OUTPUT, SYSLOG
 
 log4perl.filter.WarningsFilter                 = Log::Log4perl::Filter::StringMatch
-log4perl.filter.WarningsFilter.StringToMatch   = failed to writev: -1 errno:32|Timed out at|does not map to Unicode|Bad module supplied
+log4perl.filter.WarningsFilter.StringToMatch   = failed to writev: -1 errno:32|Timed out at|does not map to Unicode
 log4perl.filter.WarningsFilter.AcceptOnMatch   = false
 
 log4perl.appender.OUTPUT                          = Log::Log4perl::Appender::Screen