[ubu-chroot] Make bind mounts more robust and less dangerous #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main motivation for this is the issue with varying status of
moving from /dev/shm to /run/shm among distributions.
By "less dangerous" I mean removing the lines
rm -f ${uburoot}$1
mkdir -p ${uburoot}$1
which can have unintentional effects outside the chroot.
Signed-off-by: Martin Kampas <[email protected]>
|
I applied pull-request here sailfishos/android-tools-hadk@b1e3d69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention: (not only) due to the removal of the lines
this requires modification of the chroot - currently it contains /run/shm as a symlink to /dev/shm. This has to be replaced with a directory.
Note: the explicit umount will complain... this will be gone once the use of unshare -m is fixed and the workaround removed.