fix: CREATE OR MODIFY REST CLIENT reports 'Modified' for existing client (issue #421)

When CREATE OR MODIFY found and replaced an existing REST client, the
success message always said "Created". Track whether an existing service
was deleted and emit "Modified rest client" vs "Created rest client"
accordingly. Applies to both the manual definition path and the OpenAPI
import path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: ako

mdl/executor/cmd_rest_clients.go

@@ -320,13 +320,15 @@ func createRestClient(ctx *ExecContext, stmt *ast.CreateRestClientStmt) error {
 	}
 
 	var preservedID model.ID
+	wasModified := false
 	for _, existing := range existingServices {
 		existModID := h.FindModuleID(existing.ContainerID)
 		existModName := h.GetModuleName(existModID)
 		if strings.EqualFold(existModName, moduleName) && strings.EqualFold(existing.Name, stmt.Name.Name) {
 			if stmt.CreateOrModify {
 				// Preserve the existing ID so SEND REST REQUEST references stay valid after replace.
 				preservedID = existing.ID
+				wasModified = true
 				if err := ctx.Backend.DeleteConsumedRestService(existing.ID); err != nil {
 					return mdlerrors.NewBackend("delete existing rest client", err)
 				}
@@ -409,7 +411,11 @@ func createRestClient(ctx *ExecContext, stmt *ast.CreateRestClientStmt) error {
 		return mdlerrors.NewBackend("create rest client", err)
 	}
 
-	fmt.Fprintf(ctx.Output, "Created rest client: %s.%s (%d operations)\n", moduleName, stmt.Name.Name, len(svc.Operations))
+	verb := "Created"
+	if wasModified {
+		verb = "Modified"
+	}
+	fmt.Fprintf(ctx.Output, "%s rest client: %s.%s (%d operations)\n", verb, moduleName, stmt.Name.Name, len(svc.Operations))
 	return nil
 }
 
@@ -675,13 +681,15 @@ func createRestClientFromSpec(ctx *ExecContext, stmt *ast.CreateRestClientStmt)
 	if err != nil {
 		return mdlerrors.NewBackend("build hierarchy", err)
 	}
+	openAPIWasModified := false
 	for _, existing := range existingServices {
 		existModID := h.FindModuleID(existing.ContainerID)
 		existModName := h.GetModuleName(existModID)
 		if strings.EqualFold(existModName, moduleName) && strings.EqualFold(existing.Name, stmt.Name.Name) {
 			if stmt.CreateOrModify {
 				// Reuse the existing ID so microflow references stay valid.
 				svc.ID = existing.ID
+				openAPIWasModified = true
 				if err := ctx.Backend.DeleteConsumedRestService(existing.ID); err != nil {
 					return mdlerrors.NewBackend("delete existing rest client", err)
 				}
@@ -696,8 +704,12 @@ func createRestClientFromSpec(ctx *ExecContext, stmt *ast.CreateRestClientStmt)
 		return mdlerrors.NewBackend("create rest client", err)
 	}
 
-	fmt.Fprintf(ctx.Output, "Created rest client: %s.%s (%d operations from OpenAPI spec)\n",
-		moduleName, stmt.Name.Name, len(svc.Operations))
+	openAPIVerb := "Created"
+	if openAPIWasModified {
+		openAPIVerb = "Modified"
+	}
+	fmt.Fprintf(ctx.Output, "%s rest client: %s.%s (%d operations from OpenAPI spec)\n",
+		openAPIVerb, moduleName, stmt.Name.Name, len(svc.Operations))
 	return nil
 }
 

mdl/executor/cmd_rest_clients_mock_test.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/mendixlabs/mxcli/mdl/ast"
 	"github.com/mendixlabs/mxcli/mdl/backend/mock"
+	"github.com/mendixlabs/mxcli/mdl/types"
 	"github.com/mendixlabs/mxcli/model"
 )
 
@@ -95,3 +96,66 @@ func TestShowRestClients_FilterByModule(t *testing.T) {
 	assertNoError(t, listRestClients(ctx, "Integrations"))
 	assertContainsStr(t, buf.String(), "Integrations.PaymentAPI")
 }
+
+func restClientProjectVersion() *types.ProjectVersion {
+	return &types.ProjectVersion{ProductVersion: "10.6.0", MajorVersion: 10, MinorVersion: 6}
+}
+
+func TestCreateRestClient_OrModify_SaysModified(t *testing.T) {
+	mod := mkModule("MyModule")
+	existingID := nextID("crs")
+	existing := &model.ConsumedRestService{
+		BaseElement: model.BaseElement{ID: existingID},
+		ContainerID: mod.ID,
+		Name:        "WeatherAPI",
+	}
+	h := mkHierarchy(mod)
+	withContainer(h, existing.ContainerID, mod.ID)
+
+	mb := &mock.MockBackend{
+		IsConnectedFunc:    func() bool { return true },
+		ProjectVersionFunc: func() *types.ProjectVersion { return restClientProjectVersion() },
+		ListModulesFunc: func() ([]*model.Module, error) {
+			return []*model.Module{mod}, nil
+		},
+		ListConsumedRestServicesFunc: func() ([]*model.ConsumedRestService, error) {
+			return []*model.ConsumedRestService{existing}, nil
+		},
+		DeleteConsumedRestServiceFunc: func(id model.ID) error { return nil },
+		CreateConsumedRestServiceFunc: func(svc *model.ConsumedRestService) error { return nil },
+	}
+
+	ctx, buf := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	stmt := &ast.CreateRestClientStmt{
+		Name:           ast.QualifiedName{Module: "MyModule", Name: "WeatherAPI"},
+		BaseUrl:        "https://api.weather.com",
+		CreateOrModify: true,
+	}
+	assertNoError(t, createRestClient(ctx, stmt))
+	assertContainsStr(t, buf.String(), "Modified rest client")
+}
+
+func TestCreateRestClient_New_SaysCreated(t *testing.T) {
+	mod := mkModule("MyModule")
+	h := mkHierarchy(mod)
+
+	mb := &mock.MockBackend{
+		IsConnectedFunc:    func() bool { return true },
+		ProjectVersionFunc: func() *types.ProjectVersion { return restClientProjectVersion() },
+		ListModulesFunc: func() ([]*model.Module, error) {
+			return []*model.Module{mod}, nil
+		},
+		ListConsumedRestServicesFunc: func() ([]*model.ConsumedRestService, error) {
+			return nil, nil
+		},
+		CreateConsumedRestServiceFunc: func(svc *model.ConsumedRestService) error { return nil },
+	}
+
+	ctx, buf := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	stmt := &ast.CreateRestClientStmt{
+		Name:    ast.QualifiedName{Module: "MyModule", Name: "WeatherAPI"},
+		BaseUrl: "https://api.weather.com",
+	}
+	assertNoError(t, createRestClient(ctx, stmt))
+	assertContainsStr(t, buf.String(), "Created rest client")
+}

mdl/executor/cmd_rest_openapi_mock_test.go

@@ -182,13 +182,12 @@ func TestCreateRestClientFromSpec_OrModifyPreservesID(t *testing.T) {
 		return nil
 	}
 
-	ctx, _ := newMockCtx(t, withBackend(mb), withHierarchy(h))
+	ctx, buf := newMockCtx(t, withBackend(mb), withHierarchy(h))
 	stmt := &ast.CreateRestClientStmt{
 		Name:           ast.QualifiedName{Module: "PetModule", Name: "PetStoreAPI"},
 		OpenApiPath:    srv.URL,
 		CreateOrModify: true,
 	}
-
 	assertNoError(t, createRestClient(ctx, stmt))
 
 	if deletedID != existingID {
@@ -200,6 +199,7 @@ func TestCreateRestClientFromSpec_OrModifyPreservesID(t *testing.T) {
 	if created.ID != existingID {
 		t.Errorf("expected recreated service to reuse existing ID %v, got %v", existingID, created.ID)
 	}
+	assertContainsStr(t, buf.String(), "Modified rest client")
 }
 
 func TestCreateRestClientFromSpec_DuplicateWithoutOrModify(t *testing.T) {