Skip to content

Commit 05fc1d3

Browse files
akoclaude
andcommitted
test: promote .test.mdl examples to .mdl, sort by intent
Five files were excluded from \`make check-mdl\` by the .test.mdl extension despite being plain mxcli-check inputs (no @test / @expect annotations). Promoting them to .mdl puts them under CI coverage. Sorted by purpose: - doctype-tests/ keeps broad doctype overviews. Renamed in place: - 30-pluggable-widget-examples.test.mdl → 30-pluggable-widget-examples.mdl - 32-pluggable-widget-object-lists-v010.test.mdl → 32-pluggable-widget-object-lists-v010.mdl - bug-tests/ holds per-PR regression fixtures by issue number. Moved and renamed accordingly (PR origin in parens): - download_file.test.mdl → bug-tests/333-microflow-download-file.mdl (PR #333) - free_annotation.test.mdl → bug-tests/319-microflow-free-annotation.mdl (PR #319) - inheritance_split_statement.test.mdl → bug-tests/365-microflow-inheritance-split.mdl (PR #365) - 15-fragment-examples.test.mdl stays as-is — the executor does not yet support USE_FRAGMENT (parses + checks fine, but exec fails). Keeping the .test.mdl marker preserves the "not yet executable" signal. \`make check-mdl\` now also walks bug-tests/. 50 of the 59 existing bug tests pass cleanly; 9 are pre-existing failures with varied causes (intentionally-broken syntax demonstrating bugs, negative tests asserting validation fires, fixtures needing project context). They are explicitly skipped via a deny-list and logged as \`SKIP:\` so the CI signal stays meaningful while we triage them separately. Doc references updated: - docs/11-proposals/PROPOSAL_microflow_download_file_statement.md - docs/11-proposals/PROPOSAL_microflow_free_annotation.md - docs/11-proposals/PROPOSAL_microflow_inheritance_split_statement.md - docs/03-development/WIDGET_BSON_VERSION_COMPATIBILITY.md Result: 94 PASS, 9 SKIP, 0 FAIL on \`make check-mdl\`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0b366f5 commit 05fc1d3

10 files changed

Lines changed: 29 additions & 7 deletions

Makefile

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,33 @@ release: clean grammar vscode-ext sync-all
144144
test: grammar
145145
CGO_ENABLED=0 go test ./...
146146

147-
# Check MDL syntax for all doctype example scripts
147+
# Check MDL syntax for all example scripts.
148+
#
149+
# Covers both doctype-tests/ (broad doctype demos) and bug-tests/ (per-PR
150+
# regression fixtures). Skips files ending in .test.mdl — those are
151+
# mxcli-test inputs, not mxcli-check inputs.
152+
#
153+
# Nine bug-test fixtures are pre-existing failures (varied causes: some
154+
# demonstrate intentionally-broken syntax, others are negative tests
155+
# asserting validation fires, some need project context). Tracked
156+
# separately; the SKIP list keeps CI green until each is triaged.
148157
check-mdl: build
149158
@FAILED=0; \
150-
for f in mdl-examples/doctype-tests/*.mdl; do \
159+
for f in mdl-examples/doctype-tests/*.mdl mdl-examples/bug-tests/*.mdl; do \
151160
case "$$f" in *.test.mdl) continue ;; esac; \
161+
case "$$f" in \
162+
*/116-datagrid2-column-name-mismatch.mdl|\
163+
*/343-list-attribute-find-filter.mdl|\
164+
*/352-java-action-return-type-inference.mdl|\
165+
*/352-retrieve-compact-reverse-association.mdl|\
166+
*/360-import-mapping-result-type.mdl|\
167+
*/367-retrieve-sort-indirect-entity-ref.mdl|\
168+
*/369-rest-mapping-result-cardinality.mdl|\
169+
*/373-change-action-items-storage-list.mdl|\
170+
*/552-npe-reserved-words.mdl) \
171+
echo "SKIP: $$(basename "$$f") (pre-existing — tracked separately)"; \
172+
continue ;; \
173+
esac; \
152174
NAME=$$(basename "$$f"); \
153175
if ./$(BUILD_DIR)/$(BINARY_NAME) check "$$f" > /dev/null 2>&1; then \
154176
echo "PASS: $$NAME"; \

docs/03-development/WIDGET_BSON_VERSION_COMPATIBILITY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ After the first five fixes the v0.10 acceptance fixture
6666
(`mdl-examples/doctype-tests/31-pluggable-datagrid-gallery-v010-examples.mdl`)
6767
emits zero CE0463 errors on a fresh Mendix 11.9 project. The sixth fix
6868
extends this to the engine-routed widgets in
69-
`mdl-examples/doctype-tests/32-pluggable-widget-object-lists-v010.test.mdl`
69+
`mdl-examples/doctype-tests/32-pluggable-widget-object-lists-v010.mdl`
7070
`mx check` reports zero CE0463 across all six failing widget instances
7171
(`acc2`, `map1`, `map2`, `menu1`, `menu2`, `chart1`). Remaining errors on
7272
that fixture are authoring issues (missing `menuTrigger` child slot

docs/11-proposals/PROPOSAL_microflow_download_file_statement.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,4 @@ download file $GeneratedReport show in browser on error rollback;
4646

4747
- Parser/visitor coverage for both normal and `show in browser` forms.
4848
- Builder/writer coverage for `DownloadFileAction`.
49-
- Example script: `mdl-examples/doctype-tests/download_file.test.mdl`.
49+
- Example script: `mdl-examples/bug-tests/333-microflow-download-file.mdl`.

docs/11-proposals/PROPOSAL_microflow_free_annotation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ log info node 'Audit' 'starting';
4545

4646
## Tests And Examples
4747

48-
- `mdl-examples/doctype-tests/free_annotation.test.mdl` documents the supported
49-
syntax.
48+
- `mdl-examples/bug-tests/319-microflow-free-annotation.mdl` documents the
49+
supported syntax.
5050
- Parser tests cover both order-sensitive cases.
5151
- Builder tests verify that the free annotation is emitted as a standalone
5252
annotation and not attached to the activity.

docs/11-proposals/PROPOSAL_microflow_inheritance_split_statement.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Studio Pro represents specialization/type decisions as `InheritanceSplit` object
2727

2828
## Tests And Examples
2929

30-
`mdl-examples/doctype-tests/inheritance_split_statement.test.mdl` demonstrates the syntax. Go regression tests cover parser construction, builder output, describer output, validation recursion, and BSON writer support for inheritance case values and cast actions.
30+
`mdl-examples/bug-tests/365-microflow-inheritance-split.mdl` demonstrates the syntax. Go regression tests cover parser construction, builder output, describer output, validation recursion, and BSON writer support for inheritance case values and cast actions.
3131

3232
## Open Questions
3333

mdl-examples/doctype-tests/free_annotation.test.mdl renamed to mdl-examples/bug-tests/319-microflow-free-annotation.mdl

File renamed without changes.
File renamed without changes.

mdl-examples/doctype-tests/inheritance_split_statement.test.mdl renamed to mdl-examples/bug-tests/365-microflow-inheritance-split.mdl

File renamed without changes.

mdl-examples/doctype-tests/30-pluggable-widget-examples.test.mdl renamed to mdl-examples/doctype-tests/30-pluggable-widget-examples.mdl

File renamed without changes.

mdl-examples/doctype-tests/32-pluggable-widget-object-lists-v010.test.mdl renamed to mdl-examples/doctype-tests/32-pluggable-widget-object-lists-v010.mdl

File renamed without changes.

0 commit comments

Comments
 (0)