Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory: Search through "bio" and "work" #50

Open
pranavsb opened this issue Oct 5, 2020 · 1 comment
Open

Directory: Search through "bio" and "work" #50

pranavsb opened this issue Oct 5, 2020 · 1 comment
Labels
dependency depends on something external enhancement New feature or request hacktoberfest

Comments

@pranavsb
Copy link
Member

pranavsb commented Oct 5, 2020

Searching will be done on client side.

If we reuse the same search bar in directory, we have to decide if we're calling /users?search= API or doing everything locally
@pranavsb pranavsb added the enhancement New feature or request label Oct 5, 2020
@pranavsb pranavsb added the dependency depends on something external label Oct 23, 2020
@pranavsb
Copy link
Member Author

Since the recently updated /users API doesn't send all user info, client has a dependency on server to provide an easier way (rather than calling /users and then /users/<id> on every id - the easiest way is to just send bio and work fields in the /users response, but it's slow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependency depends on something external enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pranavsb @akash933