Skip to content

Commit 0603945

Browse files
bors[bot]curquiza
andauthored
Merge #138
138: Add job in CI for wasm build r=curquiza a=curquiza Should be merged after #136 Co-authored-by: Clémentine Urquizar <[email protected]>
2 parents 322fe6e + 37c6617 commit 0603945

File tree

3 files changed

+33
-14
lines changed

3 files changed

+33
-14
lines changed

.github/workflows/tests.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,13 @@ jobs:
4646
- uses: actions/checkout@v2
4747
- name: Check the README.md file is up-to-date
4848
run: sh scripts/check-readme.sh
49+
50+
wasm_build:
51+
name: wasm-build
52+
runs-on: ubuntu-latest
53+
steps:
54+
- uses: actions/checkout@v2
55+
- name: Build
56+
run: |
57+
rustup target add wasm32-unknown-unknown
58+
cargo check --example web_app --target wasm32-unknown-unknown

CONTRIBUTING.md

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
1-
# Contributing
1+
# Contributing <!-- omit in toc -->
22

33
First of all, thank you for contributing to MeiliSearch! The goal of this document is to provide everything you need to know in order to contribute to MeiliSearch and its different integrations.
44

5-
<!-- MarkdownTOC autolink="true" style="ordered" indent=" " -->
6-
75
- [Assumptions](#assumptions)
86
- [How to Contribute](#how-to-contribute)
97
- [Development Workflow](#development-workflow)
108
- [Git Guidelines](#git-guidelines)
119
- [Release Process (for internal team only)](#release-process-for-internal-team-only)
1210

13-
<!-- /MarkdownTOC -->
1411

1512
## Assumptions
1613

@@ -30,7 +27,7 @@ First of all, thank you for contributing to MeiliSearch! The goal of this docume
3027

3128
## Development Workflow
3229

33-
### Tests
30+
### Tests <!-- omit in toc -->
3431

3532
All the tests are documentation tests.<br>
3633
Since they are all making operations on the MeiliSearch server, running all the tests simultaneously would cause panics.
@@ -44,9 +41,16 @@ docker run -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=m
4441
cargo test -- --test-threads=1
4542
```
4643

44+
Also, the WASM example compilation should be checked:
45+
46+
```bash
47+
rustup target add wasm32-unknown-unknown
48+
cargo check --example web_app --target wasm32-unknown-unknown
49+
```
50+
4751
Each PR should pass the tests to be accepted.
4852

49-
### Clippy
53+
### Clippy <!-- omit in toc -->
5054

5155
Each PR should pass [`clippy`](https://github.com/rust-lang/rust-clippy) (the linter) to be accepted.
5256

@@ -67,7 +71,7 @@ rustup component add clippy
6771
rustup update
6872
```
6973

70-
### Update the README
74+
### Update the README <!-- omit in toc -->
7175

7276
The README is generated. Please do not update manually the `README.md` file.
7377

@@ -91,12 +95,12 @@ If it's not, the CI will fail on your PR.
9195

9296
## Git Guidelines
9397

94-
### Git Branches
98+
### Git Branches <!-- omit in toc -->
9599

96100
All changes must be made in a branch and submitted as PR.
97101
We do not enforce any branch naming style, but please use something descriptive of your changes.
98102

99-
### Git Commits
103+
### Git Commits <!-- omit in toc -->
100104

101105
As minimal requirements, your commit message should:
102106
- be capitalized
@@ -106,7 +110,7 @@ As minimal requirements, your commit message should:
106110

107111
We don't follow any other convention, but if you want to use one, we recommend [this one](https://chris.beams.io/posts/git-commit/).
108112

109-
### GitHub Pull Requests
113+
### GitHub Pull Requests <!-- omit in toc -->
110114

111115
Some notes on GitHub PRs:
112116

@@ -120,17 +124,17 @@ Some notes on GitHub PRs:
120124

121125
MeiliSearch tools follow the [Semantic Versioning Convention](https://semver.org/).
122126

123-
### Automation to Rebase and Merge the PRs
127+
### Automation to Rebase and Merge the PRs <!-- omit in toc -->
124128

125129
This project integrates a bot that helps us manage pull requests merging.<br>
126130
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/guides/bors.md)._
127131

128-
### Automated Changelogs
132+
### Automated Changelogs <!-- omit in toc -->
129133

130134
This project integrates a tool to create automated changelogs.<br>
131135
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/guides/release-drafter.md)._
132136

133-
### How to Publish the Release
137+
### How to Publish the Release <!-- omit in toc -->
134138

135139
⚠️ Before doing anything, make sure you got through the guide about [Releasing an Integration](https://github.com/meilisearch/integration-guides/blob/main/guides/integration-release.md).
136140

bors.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1-
status = ['integration-tests', 'clippy-check', 'readme-check']
1+
status = [
2+
'integration-tests',
3+
'clippy-check',
4+
'readme-check',
5+
'wasm-build'
6+
]
27
# 1 hour timeout
38
timeout-sec = 3600

0 commit comments

Comments
 (0)