Merge #1848

1848: Remove hint about bad Meilisearch version r=Strift a=flevi29

# Pull Request

## What does this PR do?
- removes added warnings for potential bad Meilisearch version
  - there are many more places these should be added otherwise, but that would be a lot of trouble to maintain and counter productive, so let's instead remove the outliers
  - it would also make my life easier with the upcoming #1825 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: F. Levi <[email protected]>
Co-authored-by: Laurent Cazanove <[email protected]>

Author: 3 people

src/errors/index.ts

@@ -2,4 +2,3 @@ export * from "./meilisearch-api-error.js";
 export * from "./meilisearch-request-error.js";
 export * from "./meilisearch-error.js";
 export * from "./meilisearch-timeout-error.js";
-export * from "./version-hint-message.js";

src/errors/version-hint-message.ts

@@ -5,12 +5,7 @@
  * Copyright: 2019, MeiliSearch
  */
 
-import {
-  MeiliSearchError,
-  MeiliSearchRequestError,
-  versionErrorHintMessage,
-  MeiliSearchApiError,
-} from "./errors/index.js";
+import { MeiliSearchError } from "./errors/index.js";
 import type {
   Config,
   SearchResponse,
@@ -373,22 +368,13 @@ class Index<T extends Record<string, any> = Record<string, any>> {
 
     // In case `filter` is provided, use `POST /documents/fetch`
     if (parameters.filter !== undefined) {
-      try {
-        const url = `indexes/${this.uid}/documents/fetch`;
-
-        return await this.httpRequest.post<
-          DocumentsQuery,
-          Promise<ResourceResults<D[]>>
-        >(url, parameters);
-      } catch (e) {
-        if (e instanceof MeiliSearchRequestError) {
-          e.message = versionErrorHintMessage(e.message, "getDocuments");
-        } else if (e instanceof MeiliSearchApiError) {
-          e.message = versionErrorHintMessage(e.message, "getDocuments");
-        }
-
-        throw e;
-      }
+      const url = `indexes/${this.uid}/documents/fetch`;
+
+      return await this.httpRequest.post<
+        DocumentsQuery,
+        Promise<ResourceResults<D[]>>
+      >(url, parameters);
+
       // Else use `GET /documents` method
     } else {
       const url = `indexes/${this.uid}/documents`;
@@ -601,19 +587,9 @@ class Index<T extends Record<string, any> = Record<string, any>> {
       : "documents/delete-batch";
     const url = `indexes/${this.uid}/${endpoint}`;
 
-    try {
-      const task = await this.httpRequest.post(url, params);
+    const task = await this.httpRequest.post(url, params);
 
-      return new EnqueuedTask(task);
-    } catch (e) {
-      if (e instanceof MeiliSearchRequestError && isDocumentsDeletionQuery) {
-        e.message = versionErrorHintMessage(e.message, "deleteDocuments");
-      } else if (e instanceof MeiliSearchApiError) {
-        e.message = versionErrorHintMessage(e.message, "deleteDocuments");
-      }
-
-      throw e;
-    }
+    return new EnqueuedTask(task);
   }
 
   /**

src/indexes.ts

@@ -172,9 +172,7 @@ describe("Documents tests", () => {
             "getDocuments should have raised an error when the route does not exist",
           );
         } catch (e: any) {
-          expect(e.message).toEqual(
-            "404: Not Found\nHint: It might not be working because maybe you're not up to date with the Meilisearch version that getDocuments call requires.",
-          );
+          expect(e.message).toEqual("404: Not Found");
         }
       });
 
@@ -191,8 +189,7 @@ describe("Documents tests", () => {
         } catch (e: any) {
           expect(e.message).toEqual(
             `Attribute \`id\` is not filterable. This index does not have configured filterable attributes.
-1:3 id = 1
-Hint: It might not be working because maybe you're not up to date with the Meilisearch version that getDocuments call requires.`,
+1:3 id = 1`,
           );
         }
       });
@@ -645,9 +642,7 @@ Hint: It might not be working because maybe you're not up to date with the Meili
             "deleteDocuments should have raised an error when the parameters are wrong",
           );
         } catch (e: any) {
-          expect(e.message).toEqual(
-            "Sending an empty filter is forbidden.\nHint: It might not be working because maybe you're not up to date with the Meilisearch version that deleteDocuments call requires.",
-          );
+          expect(e.message).toEqual("Sending an empty filter is forbidden.");
         }
       });
 
@@ -662,9 +657,7 @@ Hint: It might not be working because maybe you're not up to date with the Meili
             "deleteDocuments should have raised an error when the route does not exist",
           );
         } catch (e: any) {
-          expect(e.message).toEqual(
-            "404: Not Found\nHint: It might not be working because maybe you're not up to date with the Meilisearch version that deleteDocuments call requires.",
-          );
+          expect(e.message).toEqual("404: Not Found");
         }
       });