Skip to content

Commit ed92bd2

Browse files
Merge #1092
1092: Change the cmd to run the script in the node-playground r=bidoubiwa a=bidoubiwa The build command in the node playground was run whenever the release was triggered. But in reality the node playground does not need to be built, it rather runs a script to see if it can interact correctly with instant meilisearch. This PR changes the command from build to dev so that turbo build does not trigger it. It also adds a line in the test ci to ensure the script runs correctly Co-authored-by: Charlotte Vermandel <[email protected]>
2 parents c4f42c9 + 3b19b7f commit ed92bd2

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,8 @@ jobs:
9999
run: yarn test
100100
- name: Build all the playgrounds and the packages
101101
run: yarn build
102+
- name: Run the node playground
103+
run: yarn playground:node
102104
style_tests:
103105
name: style-check
104106
runs-on: ubuntu-latest

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"playground:vue3": "turbo run dev --filter=@meilisearch/vue3-ts-playground --parallel",
1818
"playground:react": "turbo run dev --filter=@meilisearch/react-playground --parallel",
1919
"playground:local-react": "turbo run dev --filter=@meilisearch/local-react-playground --parallel",
20-
"playground:node": "turbo build dev --filter=@meilisearch/node-playground --parallel",
20+
"playground:node": "turbo run dev --filter=@meilisearch/node-playground --parallel",
2121
"test:e2e": "turbo run test:e2e",
2222
"test:e2e:watch": "turbo run test:e2e:watch",
2323
"lint": "turbo lint",

playgrounds/node-env/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"description": "Instant-meilisearch playground written in node",
66
"main": "index.js",
77
"scripts": {
8-
"build": "node index.js"
8+
"dev": "node index.js"
99
},
1010
"devDependencies": {
1111
"eslint-config-meilisearch": "*"

0 commit comments

Comments
 (0)