Fix: remove newline from highlight objects (#576)

* Fix: remove newline from highlight objects

* Fix array becomming string in array highlight

Author: bidoubiwa

src/adapter/search-response-adapter/highlight-adapter.ts

@@ -19,9 +19,7 @@ function replaceHighlightTags(
   highlightPostTag = highlightPostTag || '__/ais-highlight__'
   // Highlight is applied by MeiliSearch (<em> tags)
   // We replace the <em> by the expected tag for InstantSearch
-  const stringifiedValue = isString(value)
-    ? value
-    : JSON.stringify(value, null, 2)
+  const stringifiedValue = isString(value) ? value : JSON.stringify(value)
 
   return stringifiedValue
     .replace(/<em>/g, highlightPreTag)
@@ -46,9 +44,15 @@ function adaptHighlight(
   })
   return Object.keys(formattedHit).reduce((result, key) => {
     const value = formattedHit[key]
-    result[key] = Array.isArray(value)
-      ? value.map(toHighlightMatch)
-      : toHighlightMatch(value)
+    if (Array.isArray(value)) {
+      result[key] = value.map((val) => ({
+        value: typeof val === 'object' ? JSON.stringify(val) : val,
+      }))
+    } else if (typeof value === 'object' && value !== null) {
+      result[key] = { value: JSON.stringify(value) }
+    } else {
+      result[key] = toHighlightMatch(value)
+    }
     return result
   }, {} as any)
 }

tests/highlight.tests.ts

@@ -78,6 +78,23 @@ describe('Highlight Browser test', () => {
     expect(response.results[0]?.hits[0]).not.toHaveProperty('_highlightResult')
   })
 
+  test('Test no attributesToHighlight on placeholder', async () => {
+    const response = await searchClient.search<Movies>([
+      {
+        indexName: 'movies',
+        params: {
+          attributesToHighlight: ['genres'],
+        },
+      },
+    ])
+
+    const highlightedHit = response.results[0].hits[0]._highlightResult
+    if (highlightedHit?.genres) {
+      expect(highlightedHit?.genres[0]?.value).toEqual('Adventure')
+      expect(highlightedHit?.genres[1]?.value).toEqual('Action')
+    }
+  })
+
   test('Test one attributesToHighlight on specific query', async () => {
     const response = await searchClient.search<Movies>([
       {