Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CE_CLASS_ENVY for heavy use of third-party code? #309

Open
ThrawnCA opened this issue Oct 8, 2018 · 1 comment
Open

CE_CLASS_ENVY for heavy use of third-party code? #309

ThrawnCA opened this issue Oct 8, 2018 · 1 comment
Labels
addition

Comments

@ThrawnCA
Copy link
Contributor

ThrawnCA commented Oct 8, 2018

What is the best approach to take when fb-contrib reports CE_CLASS_ENVY for our extensive use of methods from a third-party library? Just ignore it? Obviously the suggested "add this method to the other class" approach isn't an option here.
@mebigfatguy
Copy link
Owner

CE should only fire if the user and usee has similar packages. Normally in a third party situation that is not the case and CE is not fired. Is this the case here? Perhaps there is a problem with the package similarity code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mebigfatguy @ThrawnCA