Fixes #14

+ added types to tests

Author: mcurlej

joft/models.py

@@ -95,7 +95,6 @@ def __post_init__(self, reuse_data):
 class JiraTemplate:
     api_version: int
     kind: str
-    metadata: typing.Dict[str, str]
 
     # initvars
     actions: dataclasses.InitVar[typing.List[typing.Dict[str, typing.Any]]]
@@ -106,6 +105,8 @@ class JiraTemplate:
         CreateTicketAction | UpdateTicketAction | LinkIssuesAction | TransitionAction
     ] = dataclasses.field(default_factory=list)
 
+    metadata: typing.Dict[str, str] | None = None
+
     def __post_init__(self, actions, trigger) -> None:
         if trigger:
             self.jira_search: Trigger = Trigger(**trigger)

tests/test_utils.py

@@ -29,7 +29,7 @@ def test_load_invalid_yaml_raise() -> None:
 
 @unittest.mock.patch("joft.utils.pathlib.Path.cwd")
 @unittest.mock.patch("joft.utils.platformdirs")
-def test_load_toml_app_config(mock_platformdirs, mock_cwd):
+def test_load_toml_app_config(mock_platformdirs, mock_cwd) -> None:
     """Test if we can find the app config file in one of the platform dirs"""
     hostname = "test"
     pat_token = "pat_token"
@@ -60,7 +60,7 @@ def test_load_toml_app_config(mock_platformdirs, mock_cwd):
 
 @unittest.mock.patch("joft.utils.pathlib.Path.cwd")
 @unittest.mock.patch("joft.utils.platformdirs")
-def test_load_toml_app_config_no_config_found(mock_platformdirs, mock_cwd):
+def test_load_toml_app_config_no_config_found(mock_platformdirs, mock_cwd) -> None:
     """
     Test that we will end with a non-zero error code when there is no config present and
     printing a message on the stdout.