[Fix] sin_value typo, [Add] tests (#165)

Author: g5t

src/mccode_antlr/instr/orientation.py

@@ -405,6 +405,8 @@ def cos_value(v: Expr, degrees=True):
         return Expr.float(0)
     if (degrees and v.is_value(Expr.float(180))) or (not degrees and v.is_value(pi)):
         return Expr.float(-1)
+    if (degrees and v.is_value(Expr.float(-90))) or (not degrees and v.is_value(-pi/Expr.float(2))):
+        return Expr.float(0)
     return unary_expr(cos_degree if degrees else cos, 'cos', v)
 
 
@@ -416,6 +418,8 @@ def sin_value(v: Expr, degrees=True):
     if (degrees and v.is_value(Expr.float(90))) or (not degrees and v.is_value(pi / Expr.float(2))):
         return Expr.float(1)
     if (degrees and v.is_value(Expr.float(180))) or (not degrees and v.is_value(-pi / Expr.float(2))):
+        return Expr.float(0)
+    if (degrees and v.is_value(Expr.float(-90))) or (not degrees and v.is_value(-pi / Expr.float(2))):
         return Expr.float(-1)
     return unary_expr(sin_degree if degrees else sin, 'sin', v)
 
@@ -518,7 +522,7 @@ def is_rotation(self):
         # The first condition _should_ always be true -- the second is only true if this is not the identity matrix
         if round((self._axes.inverse() * self._axes).trace(), 12) == Expr.float(3.):
             return round(self._axes.trace(), 12) != Expr.float(3.)
-        logger.info(f'Not a rotation matrix: {self._axes}')
+        logger.info(f'Not a rotation matrix: {self._axes} since trace is {round((self._axes.inverse() * self._axes).trace(), 12)}')
         return False
 
     @property

tests/test_orientation.py

@@ -38,6 +38,20 @@ def _random():
 
 
 class TestOrientation(TestCase):
+    def test_simplifications_in_trig_functions(self):
+        from mccode_antlr.instr.orientation import sin_value, cos_value
+        from mccode_antlr.common import Expr
+        self.assertEqual(sin_value(Expr.float(0)), Expr.float(0))
+        self.assertEqual(sin_value(Expr.float(90)), Expr.float(1))
+        self.assertEqual(sin_value(Expr.float(-90)), Expr.float(-1))
+        self.assertEqual(sin_value(Expr.float(180)), Expr.float(0))
+
+        self.assertEqual(cos_value(Expr.float(0)), Expr.float(1))
+        self.assertEqual(cos_value(Expr.float(90)), Expr.float(0))
+        self.assertEqual(cos_value(Expr.float(-90)), Expr.float(0))
+        self.assertEqual(cos_value(Expr.float(180)), Expr.float(-1))
+
+
     def test_matrix_vector_multiply(self):
         from mccode_antlr.instr.orientation import Vector, Matrix
         from mccode_antlr.common import Expr