Alert instead of throwing exception

Author: mbelsky

package.json

@@ -11,7 +11,7 @@
     "start": "yarn backend",
     "backend": "node ./src/backend",
     "notifier": "node ./src/notifier",
-    "scraper": "node ./src/scraper",
+    "scraper": "node --inspect ./src/scraper",
     "lint": "eslint . && prettier -c .",
     "test": "yarn jest --coverage src"
   },

src/common/__tests__/getTeams.spec.js

@@ -21,9 +21,9 @@ const matches = [
   },
 ]
 
-describe('getTeams', () => {
+describe.only('getTeams', () => {
   test('getTeams', () => {
-    expect(getTeams(matches)).toMatchInlineSnapshot(`
+    expect(getTeams({ matches })).toMatchInlineSnapshot(`
       Array [
         "hellraisers",
         "melbet/extremum loser",
@@ -36,7 +36,9 @@ describe('getTeams', () => {
       ]
     `)
   })
-  test('throws exception', () => {
-    expect(() => getTeams([{ title: 'TBDvs' }])).toThrow()
+  test('invalid input returns empty array', () => {
+    const matches = [{ title: 'TBDvs' }]
+
+    expect(getTeams({ matches })).toEqual([])
   })
 })

src/common/getTeams.js

@@ -1,16 +1,28 @@
-const getMatchTeams = (match) => {
+function getMatchTeams({ alerter, match }) {
   const { title } = match
   const teams = title.toLowerCase().split(' vs ')
 
   if (2 !== teams.length) {
-    throw new Error(`Failed to get teams from '${title}'; teams=${teams}`)
+    alerter?.warn(
+      `Failed to get teams from '${title}'; teams=${teams}; match=${JSON.stringify(
+        match,
+        null,
+        2,
+      )}`,
+    )
+  }
+
+  if (1 === teams.length) {
+    return []
   }
 
   return teams
 }
 
-const getTeams = (matches) => {
-  const teams = matches.map(getMatchTeams).flat(Infinity)
+function getTeams({ alerter, matches }) {
+  const teams = matches
+    .map((match) => getMatchTeams({ alerter, match }))
+    .flat(Infinity)
 
   return [...new Set(teams)]
 }

src/notifier/makeRawMessages.js

@@ -46,7 +46,8 @@ const getFavoriteTeamsMatchesMessage = (
 
   const matches = todayMatches
     .filter((match) => {
-      const teams = getMatchTeams(match)
+      // TODO: pass alerter
+      const teams = getMatchTeams({ match })
       const isFavoriteTeamMatch =
         0 !== teams.filter((team) => favorites.includes(team)).length
 

src/scraper/scraper.js

@@ -44,7 +44,7 @@ function scrap() {
     .then(() => axios(url))
     .then(({ data }) => {
       const matches = htmlToMatches(data, { root })
-      const teams = getTeams(matches)
+      const teams = getTeams({ alerter, matches })
 
       const addTeamsPromise = addTeams(teams).catch(alerter.error)
       const saveMatchesPromise = saveFeaturedMatches(matches)