Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering for reports #3

Open
DanMan opened this issue Nov 3, 2018 · 2 comments
Open

Add filtering for reports #3

DanMan opened this issue Nov 3, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@DanMan
Copy link

DanMan commented Nov 3, 2018

So you could query the data for something like:

/games/<appId>/reports?gpuDriver=nvidia
/games/<appId>/reports?gpuDriver=nvidia&os=ubuntu

to retrieve only the ratings that have the sub-string "nvidia" in the gpuDriver field and "ubuntu" in os. Or something like:

/games/<appId>/reports?timestamp=>1540914708

to limit results to only those after 1540914708. Or

/games/<appId>/reports?os[]=mint&os[]=ubuntu

to search for either string in the os field. Or a filter for the (minimum) Proton version, …

You get the idea. It should be possible to combine them arbitrarily. Allowing RegEx syntax on the values would be nice, too.

@maxpoulin64 maxpoulin64 self-assigned this Nov 4, 2018
@maxpoulin64 maxpoulin64 added the enhancement New feature or request label Nov 4, 2018
@maxpoulin64
Copy link
Owner

I'll see what I can do. I was hoping to parse out these columns of data and store it properly in the database so I can provide APIs to search by games compatible by driver versions, by rating, and so on.

Regex does look like a pretty good stopgap solution in the meantime.

I want to make/use a query builder and implement sorting, filtering and tags all in one go later on.

@DanMan
Copy link
Author

DanMan commented Nov 4, 2018

To me the most interesting bit is currently to be able to narrow a game's reports down to "recent nvidia tests", because old tests or those for a GPU you don't have are less important. But I can also do it on the client side, no problem, no hurry. Probably even better because then I don't have to query your API as often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants