created a test to verify that link hint is shown for elements that have

delegated events philc#1404

Author: Maxim Baz

tests/dom_tests/dom_tests.coffee

@@ -58,6 +58,28 @@ createGeneralHintTests = (isFilteredMode) ->
       assertStartPosition document.getElementsByTagName("a")[1], hintMarkers[1]
       LinkHints.deactivateMode()
 
+  # See here about jQuery delegated events: https://api.jquery.com/on/#direct-and-delegated-events
+  context "Link hints for jQuery delegated events",
+    setup ->
+      stub settings.values, "filterLinkHints", isFilteredMode
+      stub settings.values, "linkHintCharacters", "ab"
+
+      clickableSpan = "<span class='clickable'>Click me</span>" + "<span>Don't click me</span>"
+      document.getElementById("test-div").innerHTML = clickableSpan
+
+      $(document).on 'click', '.clickable', ( -> )
+
+      LinkHints.init()
+      LinkHints.activateMode()
+
+    tearDown ->
+      LinkHints.deactivateMode()
+      document.getElementById("test-div").innerHTML = ""
+
+    should "create links for elements, that have delegated event handler assigned", ->
+      assert.equal 1, getHintMarkers().length
+
+
 createGeneralHintTests false
 createGeneralHintTests true
 

tests/dom_tests/dom_tests.html

@@ -27,8 +27,13 @@
       }
     </style>
     <link rel="stylesheet" type="text/css" href="../../content_scripts/vimium.css" />
+
+    <!-- Simulate the load of injected hooks -->
+    <script type="text/javascript" src="../../pages/addEventListener_hook.js"></script>
+
     <script type="text/javascript" src="bind.js"></script>
     <script type="text/javascript" src="chrome.js"></script>
+    <script type="text/javascript" src="jquery-2.1.1.min.js"></script>
     <script type="text/javascript" src="../../lib/utils.js"></script>
     <script type="text/javascript" src="../../lib/keyboard_utils.js"></script>
     <script type="text/javascript" src="../../lib/dom_utils.js"></script>