Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.25.1 FTBFS (Android) #8625

Open
uusijani opened this issue Feb 21, 2025 · 4 comments
Open

v2.25.1 FTBFS (Android) #8625

uusijani opened this issue Feb 21, 2025 · 4 comments

Comments

@uusijani
Copy link

Trying to build v2.25.1 (npm build:android) fails with what looks like a missing dependency. This was not an issue with v2.25.0, so the cause is some recent change.

The full log is below, but here's what I think is the crucial part:

* What went wrong:
Could not determine the dependencies of task ':app:mergeReleaseNativeLibs'.
> Could not resolve all dependencies for configuration ':app:releaseRuntimeClasspath'.
   > Could not resolve project :frameanimation.
     Required by:
         project :app > project :expo > project :expo-image
      > No matching variant of project :frameanimation was found. The consumer was configured to find a library for use during runtime, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '8.2.1', attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release', attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but:
          - No variants exist.
   > Could not resolve project :gif.
     Required by:
         project :app > project :expo > project :expo-image
      > No matching variant of project :gif was found. The consumer was configured to find a library for use during runtime, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '8.2.1', attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release', attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but:
          - No variants exist.

fail.log

@licaon-kter
Copy link

@Booqka
Copy link

Booqka commented Feb 24, 2025

@rahimrahman could you please take a look at it? Seems like that one happened after your changes. I've met that one on 2.25.1 too.

@rahimrahman
Copy link
Contributor

@Booqka @uusijani

The reason for this is because we had to fork a dependency (APNG4Android) of a dependency (Expo Image). This APNG4Android library is not an npm library, so it is not installable with an npm install, thus it requires the postinstall.sh to install it afterwards. Some reason, I think your solidarity is failing, thus causing the postinstall.sh to not execute afterwards.

./scripts/postinstall.sh

APNG4Android="node_modules/APNG4Android"
if [ ! -z "$APNG4Android" ]; then
    git clone -b "fix/MM-62375-OOM-on-gif-with-build-updates-2" --single-branch --depth 1 https://github.com/mattermost/APNG4Android.git "$APNG4Android";
fi

But in any case, I think I'm going to try to make it an npm installable library instead (by adding package.json) even though there are no js sources. Maybe that'll help?

I'll let you all know soon.

@rahimrahman
Copy link
Contributor

Also, some folks have brought this up in the community:

One dev is using

npm install --ignore-scripts

So that could be the reason why it's not running the postinstall script for you all too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants