Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes SiteUrl customization #65

Open
vthomas73 opened this issue Jan 24, 2025 · 2 comments · May be fixed by #67
Open

Kubernetes SiteUrl customization #65

vthomas73 opened this issue Jan 24, 2025 · 2 comments · May be fixed by #67

Comments

@vthomas73
Copy link

vthomas73 commented Jan 24, 2025

When used in a Kubernetes environment, the mattermost domain used for the job is not necessarily the one provided by the mattermost's payload inputs, especially if you want to use internal k8s service.
Moreover, when it uses the default url given in the payload, the connection is mostly made through the ingress which doesn't make sense especially if you have Self-Signed certificate in the ingress, it makes the offloader invalidating all the requests because of the impossibility to check the signature.
Would be great to be able to use a custom domain in order to specify a service instead of the public mattermost url

@vthomas73
Copy link
Author

vthomas73 commented Jan 24, 2025

When used in a Kubernetes environment, the mattermost domain used for the job is not necessarily the one provided by the mattermost's payload inputs, especially if you want to use internal k8s service. Moreover, when it uses the default url given in the payload, the connection is made through the ingress which doesn't make sense especially if you have Self-Signed certificate in the ingress, it make the offloader crashing.

I do have a PR to submit, just need to be accepted by your Contributor License Agreement. Can you also assign me the issue as the contribution checklist expalins please ?

@streamer45
Copy link
Contributor

@vthomas73 Not sure if I fully understood the issue, but we support some level of customization on the plugin side through the MM_CALLS_RECORDER_SITE_URL and MM_CALLS_TRANSCRIBER_SITE_URL environment variables.

See https://docs.mattermost.com/configure/plugins-configuration-settings.html#job-service-url

@streamer45 streamer45 linked a pull request Feb 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants