Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice to have a capistrano+airbrussh integration test #37

Open
mattbrictson opened this issue Jul 5, 2015 · 1 comment
Open

Comments

@mattbrictson
Copy link
Owner

Airbrussh works by hooking into capistrano, and these hooks are currently not integration tested. If capistrano were to change its APIs, there could be a situation where the airbrussh unit tests continue to pass even though it no longer works in practice. Therefore an integration test would be nice to have.

Perhaps the test would create a sample app in a temporary directory with a Gemfile containing capistrano and airbrussh (the latter would point to the version of airbrussh under test using path), then:

  • bundle exec cap install STAGES=test
  • Add require "airbrussh/capistrano" to the generated Capfile
  • Comment out set :format, :pretty in the generated deploy.rb (if necessary)
  • Add a sample rake task to deploy.rb that executes something with the local backend
  • bundle exec cap test sample_task

Verify that that output is indeed airbrussh-formatted and that cap exited successfully.

@mattbrictson mattbrictson changed the title Add integration test It would be nice to have a capistrano+airbrussh integration test Jul 5, 2015
@mattbrictson
Copy link
Owner Author

Recently discovered bugs #42 and #43 would not have been caught by this simple integration test. An effective integration test would probably require the real net-ssh backend and a Vagrant box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant