Skip to content

add tests via nbval #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianhi opened this issue Sep 8, 2020 · 6 comments · Fixed by #272
Closed

add tests via nbval #265

ianhi opened this issue Sep 8, 2020 · 6 comments · Fixed by #272

Comments

@ianhi
Copy link
Collaborator

ianhi commented Sep 8, 2020

Describe the issue

It would be great to have a test notebook that was run using nbval and tested against several version of matplotlib as well matplotlib master maybe? This could help pick up errors like #252 more quickly.

@martinRenou
Copy link
Member

I agree. We might not even need nbval, a simpler test set with pytest might be enough?

@ianhi
Copy link
Collaborator Author

ianhi commented Sep 8, 2020

Do methods such as display get properly tested by pytest?

@ianhi
Copy link
Collaborator Author

ianhi commented Sep 8, 2020

Also, if we use jupyterlab-browsercheck maybe we could notice the javascript errors that come from a broken install? I think we added that to ipycytoscape

@martinRenou
Copy link
Member

I think we added that to ipycytoscape

Oh did you? I am really interested in this!

@ianhi
Copy link
Collaborator Author

ianhi commented Sep 8, 2020

I'm not entirely sure that I added it correctly or that it would pick up every pathology. See dicussion about adding it here: cytoscape/ipycytoscape#131 (added both browser check and build in the PR)

@ianhi
Copy link
Collaborator Author

ianhi commented Sep 8, 2020

If the browser check could be made to run a few cells of a notebook then it would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants