-
Notifications
You must be signed in to change notification settings - Fork 227
add tests via nbval #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree. We might not even need nbval, a simpler test set with pytest might be enough? |
Do methods such as |
Also, if we use jupyterlab-browsercheck maybe we could notice the javascript errors that come from a broken install? I think we added that to ipycytoscape |
Oh did you? I am really interested in this! |
I'm not entirely sure that I added it correctly or that it would pick up every pathology. See dicussion about adding it here: cytoscape/ipycytoscape#131 (added both browser check and build in the PR) |
If the browser check could be made to run a few cells of a notebook then it would be awesome. |
Describe the issue
It would be great to have a test notebook that was run using nbval and tested against several version of matplotlib as well matplotlib master maybe? This could help pick up errors like #252 more quickly.
The text was updated successfully, but these errors were encountered: