Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to specify an aspect ratio for SquareStrategy #51

Open
pganssle opened this issue Feb 25, 2019 · 0 comments
Open

Allow users to specify an aspect ratio for SquareStrategy #51

pganssle opened this issue Feb 25, 2019 · 0 comments

Comments

@pganssle
Copy link
Member

Per my comments in #50, I think we should probably create a version of SquareStrategy that allows you to specify a target aspect ratio other than 1:1.

The nomenclature is all messed up and I'm wondering if we should rename this project and a bunch of the classes in it before too many people start using it, but for now we can just call it RectangleStrategy, and make SquareStrategy a subclass of it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pganssle