Skip to content

Commit 6ac742f

Browse files
authored
Merge pull request #799 from mathematicalthinking/validateJSImport
Make validate.js a regular import
2 parents eee8767 + 127d34e commit 6ac742f

9 files changed

Lines changed: 18 additions & 20 deletions

app/components/answer-new.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import ErrorHandlingComponent from './error-handling';
22
import { tracked } from '@glimmer/tracking';
33
import { action } from '@ember/object';
44
import isEqual from 'lodash/isEqual';
5-
import { inject as service } from '@ember/service';
5+
import { service } from '@ember/service';
6+
import validate from 'validate.js';
67
import $ from 'jquery';
78
import { all, reject, resolve } from 'rsvp';
89

@@ -292,7 +293,7 @@ export default class AnswerNew extends ErrorHandlingComponent {
292293
};
293294
let constraints = this.constraints;
294295

295-
let errors = window.validate(values, constraints);
296+
let errors = validate(values, constraints);
296297
if (errors) {
297298
for (let key of Object.keys(errors)) {
298299
let errorProp = `${key}Errors`;

app/components/assignment-new.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import Component from '@glimmer/component';
22
import { tracked } from '@glimmer/tracking';
33
import { action } from '@ember/object';
44
import { service } from '@ember/service';
5+
import validate from 'validate.js';
56
import moment from 'moment';
67

78
export default class AssignmentNewComponent extends Component {
@@ -388,7 +389,7 @@ export default class AssignmentNewComponent extends Component {
388389

389390
const constraints = this.constraints;
390391

391-
let errors = window.validate(values, constraints);
392+
let errors = validate(values, constraints);
392393
if (errors) {
393394
// errors
394395
for (let key of Object.keys(errors)) {

app/components/search-bar.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import Component from '@ember/component';
22
import { computed } from '@ember/object';
33
/*global _:false */
44
import { alias } from '@ember/object/computed';
5+
import validate from 'validate.js';
56

67
export default Component.extend({
78
classNames: ['search-bar-comp'],
@@ -117,7 +118,7 @@ export default Component.extend({
117118
let values = { query: val };
118119
let constraints = this.inputConstraints;
119120

120-
let errors = window.validate(values, constraints);
121+
let errors = validate(values, constraints);
121122
if (errors) {
122123
for (let key of Object.keys(errors)) {
123124
let errorProp = `${key}Errors`;

app/components/section-new.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import ErrorHandlingComponent from './error-handling';
22
import { tracked } from '@glimmer/tracking';
33
import { action } from '@ember/object';
44
import { later } from '@ember/runloop';
5-
import { inject as service } from '@ember/service';
5+
import { service } from '@ember/service';
6+
import validate from 'validate.js';
67
import $ from 'jquery';
78

89
export default class SectionNewComponent extends ErrorHandlingComponent {
@@ -110,7 +111,7 @@ export default class SectionNewComponent extends ErrorHandlingComponent {
110111
teacher: teacher,
111112
organization: organization,
112113
};
113-
let validation = window.validate(values, constraints);
114+
let validation = validate(values, constraints);
114115
if (validation) {
115116
// errors
116117
for (let key of Object.keys(validation)) {

app/components/workspace-new-settings.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import Component from '@ember/component';
22
import { computed } from '@ember/object';
33
/*global _:false */
4-
import { inject as service } from '@ember/service';
4+
import { service } from '@ember/service';
5+
import validate from 'validate.js';
56

67
export default Component.extend({
78
elementId: 'workspace-new-settings',
@@ -200,7 +201,7 @@ export default Component.extend({
200201
const permissions = this.workspacePermissions;
201202
const submissionSettings = this.selectedSubmissionSettings;
202203

203-
errors = window.validate(
204+
errors = validate(
204205
{ workspaceName, owner, privacySetting },
205206
this.constraints
206207
);

app/components/ws-copy-owner-settings.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import Component from '@ember/component';
22
import { computed } from '@ember/object';
33
/*global _:false */
4-
import { inject as service } from '@ember/service';
4+
import { service } from '@ember/service';
5+
import validate from 'validate.js';
56
import CurrentUserMixin from '../mixins/current_user_mixin';
67

78
export default Component.extend(CurrentUserMixin, {
@@ -183,12 +184,12 @@ export default Component.extend(CurrentUserMixin, {
183184
if (!doCreateFolderSet) {
184185
this.set('folderSetName', null);
185186
this.set('folderSetPrivacy', null);
186-
errors = window.validate(
187+
errors = validate(
187188
{ name, owner, mode, doCreateFolderSet },
188189
this.constraints
189190
);
190191
} else {
191-
errors = window.validate(
192+
errors = validate(
192193
{
193194
name,
194195
owner,

ember-cli-build.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ module.exports = function (defaults) {
1717
*/
1818

1919
app.import('vendor/guiders.js');
20-
app.import('vendor/validate.min.js');
2120
app.import('vendor/dropzone.js');
2221

2322
// Use `app.import` to add additional libraries to the generated

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@
9090
"typeahead.js": "^0.11.1",
9191
"underscore": "^1.13.6",
9292
"uuid": "^8.3.2",
93+
"validate.js": "^0.13.1",
9394
"wordcloud": "^1.2.2"
9495
},
9596
"devDependencies": {

vendor/validate.min.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)