[Catalog][DatePicker] navigation bar has no contrast if edge to edge setting is on #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drchen
reviewed
Jan 2, 2025
| Fragment fragment = getChildFragmentManager().findFragmentByTag("MaterialDatePicker"); | ||
| if (fragment instanceof MaterialDatePicker<?>) { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { | ||
| view.post(() -> { |
There was a problem hiding this comment.
Move the whole view.pose(....) part to a private method to avoid duplicated codes?
There was a problem hiding this comment.
Thank you. I created navigationBarContrast() method.
drchen
reviewed
Jan 2, 2025
| @@ -163,13 +166,30 @@ public View onCreateDemoView( | |||
| builder.setCalendarConstraints(constraintsBuilder.build()); | |||
| MaterialDatePicker<?> picker = builder.build(); | |||
| addSnackBarListeners(picker); | |||
| picker.show(getChildFragmentManager(), picker.toString()); | |||
| picker.show(getChildFragmentManager(), "MaterialDatePicker"); | |||
There was a problem hiding this comment.
Why did you change picker.toString() to a string constant?
There was a problem hiding this comment.
I changed it to find the fragment by findFragmentByTag("MaterialDatePicker").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4501