sql script is added#161
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good effort on setting up the database schema. However, there are a few critical issues in your SQL script that prevent it from running correctly, so I am requesting some changes.
First, all of your FOREIGN KEY definitions have syntax errors. The column name must be enclosed in parentheses, like FOREIGN KEY (CustomerID) REFERENCES Customers(ID). Additionally, in the OrderItems table, you're missing a comma between the two foreign key constraints.
Second, the Price column in the Products table uses the FLOAT data type, which is not permitted by the task requirements. Please use one of the allowed types, such as INT, to store the price (for example, in cents).
Lastly, it's a good practice to add a USE ShopDB; command right after you create the database to ensure the tables are created in the correct place. Please fix these issues and resubmit.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I am happy to approve your solution. You've successfully addressed all the feedback from the previous review, and the task.sql script now correctly creates the ShopDB database and all its tables with the proper columns, data types, and foreign key relationships. Everything aligns perfectly with the task requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
3 participants
No description provided.