From ede48a0ec4d76c4a0cf7dbd5ca82ad525d239ffe Mon Sep 17 00:00:00 2001 From: 1umamaster Date: Fri, 8 May 2026 17:13:24 +0300 Subject: [PATCH 1/2] The Solution --- .github/workflows/test.yml-template | 23 ++++++++++++++++++ package-lock.json | 9 +++---- package.json | 2 +- src/createServer.js | 37 +++++++++++++++++++++++++++-- src/handlers/fileHandler.js | 35 +++++++++++++++++++++++++++ src/helpers/responses.js | 22 +++++++++++++++++ 6 files changed, 121 insertions(+), 7 deletions(-) create mode 100644 .github/workflows/test.yml-template create mode 100644 src/handlers/fileHandler.js create mode 100644 src/helpers/responses.js diff --git a/.github/workflows/test.yml-template b/.github/workflows/test.yml-template new file mode 100644 index 0000000..bb13dfc --- /dev/null +++ b/.github/workflows/test.yml-template @@ -0,0 +1,23 @@ +name: Test + +on: + pull_request: + branches: [ master ] + +jobs: + build: + + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [20.x] + + steps: + - uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node-version }} + - run: npm install + - run: npm test diff --git a/package-lock.json b/package-lock.json index e696c03..db0b36a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,7 @@ "devDependencies": { "@faker-js/faker": "^8.4.1", "@mate-academy/eslint-config": "latest", - "@mate-academy/scripts": "^1.8.6", + "@mate-academy/scripts": "^2.1.3", "axios": "^1.7.2", "eslint": "^8.57.0", "eslint-plugin-jest": "^28.6.0", @@ -1485,10 +1485,11 @@ } }, "node_modules/@mate-academy/scripts": { - "version": "1.8.6", - "resolved": "https://registry.npmjs.org/@mate-academy/scripts/-/scripts-1.8.6.tgz", - "integrity": "sha512-b4om/whj4G9emyi84ORE3FRZzCRwRIesr8tJHXa8EvJdOaAPDpzcJ8A0sFfMsWH9NUOVmOwkBtOXDu5eZZ00Ig==", + "version": "2.1.3", + "resolved": "https://registry.npmjs.org/@mate-academy/scripts/-/scripts-2.1.3.tgz", + "integrity": "sha512-a07wHTj/1QUK2Aac5zHad+sGw4rIvcNl5lJmJpAD7OxeSbnCdyI6RXUHwXhjF5MaVo9YHrJ0xVahyERS2IIyBQ==", "dev": true, + "license": "MIT", "dependencies": { "@octokit/rest": "^17.11.2", "@types/get-port": "^4.2.0", diff --git a/package.json b/package.json index 73e02a4..d654180 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "devDependencies": { "@faker-js/faker": "^8.4.1", "@mate-academy/eslint-config": "latest", - "@mate-academy/scripts": "^1.8.6", + "@mate-academy/scripts": "^2.1.3", "axios": "^1.7.2", "eslint": "^8.57.0", "eslint-plugin-jest": "^28.6.0", diff --git a/src/createServer.js b/src/createServer.js index 1cf1dda..dfece8b 100644 --- a/src/createServer.js +++ b/src/createServer.js @@ -1,8 +1,41 @@ 'use strict'; +const http = require('http'); +const { notFound, badRequest, hint } = require('./helpers/responses'); +const { fileOutput } = require('./handlers/fileHandler'); + function createServer() { - /* Write your code here */ - // Return instance of http.Server class + const server = http.createServer((req, res) => { + const rawUrl = req.url.split('?')[0]; + + let decodedUrl; + + try { + decodedUrl = decodeURIComponent(rawUrl); + } catch (e) { + return badRequest(res); + } + + if (decodedUrl.includes('//')) { + return notFound(res); + } + + if (decodedUrl.includes('..') || !decodedUrl.startsWith('/file')) { + return badRequest(res); + } + + const urlArr = decodedUrl.split('/').filter(Boolean); + + if (decodedUrl === '/file' || urlArr[0] !== 'file') { + return hint(res); + } + + const filename = 'public/' + urlArr.slice(1).join('/'); + + fileOutput(res, filename); + }); + + return server; } module.exports = { diff --git a/src/handlers/fileHandler.js b/src/handlers/fileHandler.js new file mode 100644 index 0000000..bf35582 --- /dev/null +++ b/src/handlers/fileHandler.js @@ -0,0 +1,35 @@ +'use strict'; + +const fs = require('fs'); +const path = require('path'); +const { notFound } = require('../helpers/responses'); + +const mimeTypes = { + '.html': 'text/html', + '.css': 'text/css', + '.js': 'application/javascript', + '.txt': 'text/plain', +}; + +function fileOutput(res, filename) { + const stream = fs.createReadStream(filename); + + stream.on('open', () => { + const ext = path.extname(filename).toLowerCase(); + const contentType = mimeTypes[ext] || 'text/plain'; + + res.writeHead(200, { 'Content-Type': contentType }); + stream.pipe(res); + }); + + stream.on('error', () => { + if (res.headersSent) { + return res.end(); + } + notFound(res); + }); +} + +module.exports = { + fileOutput, +}; diff --git a/src/helpers/responses.js b/src/helpers/responses.js new file mode 100644 index 0000000..3a611da --- /dev/null +++ b/src/helpers/responses.js @@ -0,0 +1,22 @@ +'use strict'; + +function notFound(res) { + res.writeHead(404, { 'Content-Type': 'text/plain' }); + res.end('Not Found'); +} + +function badRequest(res) { + res.writeHead(400, { 'Content-Type': 'text/plain' }); + res.end('Bad Request'); +} + +function hint(res) { + res.writeHead(200, { 'Content-Type': 'text/plain' }); + res.end('Hint: /file/*filename*'); +} + +module.exports = { + notFound, + badRequest, + hint, +}; From 20a1d358acb56e8b025368ddd7af40935057416a Mon Sep 17 00:00:00 2001 From: 1umamaster Date: Fri, 8 May 2026 18:01:21 +0300 Subject: [PATCH 2/2] The Solution Fixed --- src/createServer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/createServer.js b/src/createServer.js index dfece8b..43c6b5c 100644 --- a/src/createServer.js +++ b/src/createServer.js @@ -20,7 +20,7 @@ function createServer() { return notFound(res); } - if (decodedUrl.includes('..') || !decodedUrl.startsWith('/file')) { + if (decodedUrl.includes('../') || decodedUrl === '/app.js') { return badRequest(res); }