Skip to content

The Solution #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1umamaster wants to merge 2 commits into
base: master
Choose a base branch
from
Open

The Solution #1112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7e8f37
The Solution
1umamaster Apr 18, 2026
13fdd1c
The Solution Fixed
1umamaster Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
Comment on lines +1 to +3
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.yml-template duplicates the existing .github/workflows/test.yml but (because of its extension) won't be picked up by GitHub Actions. If it's not intentionally a reference file, it should be removed; otherwise consider moving it out of .github/workflows/ or adding a short comment explaining its purpose to avoid confusion.

Copilot uses AI. Check for mistakes.
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
Comment on lines +17 to +22
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow uses deprecated/outdated action versions (actions/checkout@v2, actions/setup-node@v1). Update to currently supported majors (e.g., checkout@v4, setup-node@v4) and consider using npm ci for reproducible installs in CI.

Suggested change
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci

Copilot uses AI. Check for mistakes.
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
56 changes: 56 additions & 0 deletions src/createServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,59 @@
/* eslint-disable max-len */
// Write code here
// Also, you can create additional files in the src folder
// and import (require) them here

const http = require('http');
const { convertToCase } = require('./convertToCase');

const createServer = () => {
return http.createServer((req, res) => {
res.setHeader('Content-Type', 'application/json');

const cases = ['SNAKE', 'KEBAB', 'CAMEL', 'PASCAL', 'UPPER'];
const url = new URL(req.url, `http://${req.headers.host}`);
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cases is recreated on every request. Since this list is constant, define it once outside the request handler (and optionally use a Set for lookups) to reduce per-request allocations and keep validation logic centralized.

Copilot uses AI. Check for mistakes.
const toCase = url.searchParams.get('toCase');
const text = url.pathname.slice(1);
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code constructs a URL instance and uses url.searchParams to get query params and url.pathname for text. The task explicitly requires splitting req.url by ? and using the global URLSearchParams to parse the query string (see checklist items #23, #25 and #20). Please change the parsing to follow the required approach, e.g. split req.url into [path, queryString], use new URLSearchParams(queryString) and then params.get('toCase'), and derive text from the path part (slice off the leading '/').

const errors = { errors: [] };
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new URL(req.url, �http://${req.headers.host}�) will throw if the request lacks a Host header (e.g., HTTP/1.0, some proxies, or malformed clients), which would crash the request handler. Consider using a fixed base URL (e.g., http://localhost) or a safe fallback when req.headers.host is missing, and return a 400 error if the URL can't be parsed.

Suggested change
const url = new URL(req.url, `http://${req.headers.host}`);
const toCase = url.searchParams.get('toCase');
const text = url.pathname.slice(1);
const errors = { errors: [] };
const errors = { errors: [] };
const baseUrl = `http://${req.headers.host || 'localhost'}`;
let url;
try {
url = new URL(req.url, baseUrl);
} catch (error) {
res.statusCode = 400;
res.statusMessage = 'Bad request';
res.end(
JSON.stringify({
errors: [
{
message:
'Invalid request URL. Correct request is: "/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".',
},
],
}),
);
return;
}
const toCase = url.searchParams.get('toCase');
const text = url.pathname.slice(1);

Copilot uses AI. Check for mistakes.

Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const text = url.pathname.slice(1) leaves percent-encoded characters intact (e.g., /hello%20world becomes hello%20world), which can lead to incorrect conversions for inputs containing spaces or non-ASCII characters. Decode the path segment (e.g., via decodeURIComponent) before passing it to convertToCase.

Suggested change
const text = url.pathname.slice(1);
const errors = { errors: [] };
const rawText = url.pathname.slice(1);
let text = '';
const errors = { errors: [] };
try {
text = decodeURIComponent(rawText);
} catch (error) {
errors.errors.push({
message:
'Text to convert contains invalid percent-encoding. Correct request is: "/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".',
});
}

Copilot uses AI. Check for mistakes.
if (text.length < 1) {
errors.errors.push({
message:
'Text to convert is required. Correct request is: "/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".',
});
}

if (!toCase) {
errors.errors.push({
message:
'"toCase" query param is required. Correct request is: "/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".',
});
}

if (toCase && !cases.includes(toCase)) {
errors.errors.push({
message: `This case is not supported. Available cases: SNAKE, KEBAB, CAMEL, PASCAL, UPPER.`,
});
}

if (errors.errors.length > 0) {
res.statusCode = 400;
res.statusMessage = 'Bad request';
res.end(JSON.stringify(errors));

return;
}

const result = convertToCase(text, toCase);

result.originalText = text;
result.targetCase = toCase;

res.statusCode = 200;
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On success you set res.statusCode = 200 but do not set res.statusMessage. The requirements state the server should respond with status 200 and statusText OK (checklist item #15). Add res.statusMessage = 'OK' before sending the response.

res.end(JSON.stringify(result));
});
};

module.exports = {
createServer,
};
Loading