-
Notifications
You must be signed in to change notification settings - Fork 995
implemented user authentication #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Let's fix some comments
| public boolean login(String email, String password) { | ||
| return false; | ||
| public static boolean login(String email, String password) { | ||
| User user = new User(email, password); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create UserService as class-level variable
find user by email
user ternary operator in return
| * Return <code>null</code> if there is no suitable user | ||
| */ | ||
| public User findByEmail(String email) { | ||
| public static User findByEmail(String email) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| public static User findByEmail(String email) { | |
| public User findByEmail(String email) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Co-authored-by: Olena Bruiako <[email protected]>
No description provided.