Skip to content

task solution#1310

Open
vectormeleshko wants to merge 3 commits into
mate-academy:masterfrom
vectormeleshko:master
Open

task solution#1310
vectormeleshko wants to merge 3 commits into
mate-academy:masterfrom
vectormeleshko:master

Conversation

@vectormeleshko

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation has a critical bug that causes 2 of 13 tests to fail. While the disable logic works correctly (buttons are visually disabled at 10), users can still click the disabled buttons and add extra rows/columns, allowing 11 instead of the required maximum of 10. The fix is straightforward: add a guard in your click handlers to check the count before adding. In your .append-row handler, wrap the add logic in if (getRows().length < 10) { /* add row */ }, and similarly for .append-column with getColumns().length < 10. This ensures the max limit is truly enforced, not just visually indicated. Once you add these guards and the tests pass, your solution will be complete.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants