Docker setup for ToDo app by verteiger · Pull Request #297 · mate-academy/devops_todolist

verteiger · 2026-05-17T09:56:31Z

No description provided.

mateacademy-ai-mentor

Review Summary

The implementation has critical tag mismatches that violate explicit task requirements. Task requirement #8 requires the image to be named todoapp, and requirement #9 requires it to be tagged with 1.0.0. However, the Dockerfile and INSTRUCTION.md use verteiger/todoapp:latest throughout, which fails both requirements. You need to: (1) Change the build tag from -t verteiger/todoapp:latest to -t todoapp:1.0.0 in the Dockerfile, (2) Update all references in INSTRUCTION.md from todoapp:latest to todoapp:1.0.0 in build, run, tag, push commands, and docker-compose service, (3) Verify the Docker Hub repository name matches your actual account. The technical implementation (multi-stage build, ARG, ENV PYTHONUNBUFFERED=1, migration RUN, runserver with 0.0.0.0:8080) is correct, but the tag naming must be fixed to meet the requirements.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+
+### Runtime stage
+FROM python:${PYTHON_VERSION}-slim
+


The image is built with tag verteiger/todoapp:latest but task requirement #8 specifies it should be named todoapp. Change -t verteiger/todoapp:latest to -t todoapp:1.0.0 to match the requirement.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+         gcc \
+         python3-dev \
+         libbz2-dev \
+         libssl-dev \


The image tag mentioned is latest but task requirement #9 requires the image to be pushed with 1.0.0 tag (todoapp:1.0.0). Update all references from latest to 1.0.0.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+
+WORKDIR /app
+
+# Create non-root user


Image tag should be 1.0.0 instead of latest to match task requirement #9.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+RUN chown -R appuser:appuser /app
+
+# Switch to non-root user
+USER appuser


Image tag should be 1.0.0 instead of latest to match task requirement #9.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+
+RUN python manage.py migrate
+
+# Application port


Image tag should be 1.0.0 instead of latest to match task requirement #9.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+	docker pull verteiger/todoapp:latest
+
+2. Run the container, mapping the container port 8080 to a host port (example uses host port 8000):
+


The pull command uses todoapp:latest but should reference todoapp:1.0.0 to match the task requirement for the specific tag.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+	docker build -t verteiger/todoapp:latest .
+
+2. Run the locally-built image:
+


The run command uses todoapp:latest but should use todoapp:1.0.0 to match the specified tag in the task requirements.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+	docker login
+
+2. Tag the image (if needed):
+


The tag command uses todoapp:latest but should be todoapp:1.0.0 as specified in the task requirement.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+	docker tag verteiger/todoapp:latest verteiger/todoapp:latest
+
+3. Push:
+


The push command uses todoapp:latest but should push todoapp:1.0.0 to match the task requirement.

mateacademy-ai-mentor · 2026-05-17T09:58:12Z

+```yaml
+version: '3.8'
+services:
+  todoapp:


The docker-compose service uses todoapp:latest image tag but should use todoapp:1.0.0 for consistency with the task requirement.

verteiger

fixed

verteiger · 2026-05-17T10:11:25Z

+
+FROM python:${PYTHON_VERSION}-slim AS builder
+
+WORKDIR /app


verteiger · 2026-05-17T10:11:35Z

+         gcc \
+         python3-dev \
+         libbz2-dev \
+         libssl-dev \


verteiger · 2026-05-17T10:11:44Z

+
+### Runtime stage
+FROM python:${PYTHON_VERSION}-slim
+


verteiger · 2026-05-17T10:11:54Z

+
+WORKDIR /app
+
+# Create non-root user


verteiger · 2026-05-17T10:12:03Z

+RUN chown -R appuser:appuser /app
+
+# Switch to non-root user
+USER appuser


verteiger · 2026-05-17T10:12:18Z

+	docker build -t verteiger/todoapp:latest .
+
+2. Run the locally-built image:
+


verteiger · 2026-05-17T10:12:23Z

+	docker build -t verteiger/todoapp:latest .
+
+2. Run the locally-built image:
+


verteiger · 2026-05-17T10:12:26Z

+	docker login
+
+2. Tag the image (if needed):
+


verteiger · 2026-05-17T10:12:30Z

+	docker tag verteiger/todoapp:latest verteiger/todoapp:latest
+
+3. Push:
+


verteiger · 2026-05-17T10:12:33Z

+```yaml
+version: '3.8'
+services:
+  todoapp:


verteiger · 2026-05-17T10:17:19Z

pls check

verteiger · 2026-05-17T10:24:34Z

@mateacademy-ai-mentor pls check

verteiger and others added 3 commits May 8, 2026 01:06

Add DockerFile

91dffd6

Add initial Dockerfile for Python Flask application

e4867c1

Add Dockerfile and INSTRUCTION.md for container setup and usage

7dc1f49

mateacademy-ai-mentor suggested changes May 17, 2026

View reviewed changes

fix tag name

505a1d2

verteiger commented May 17, 2026

View reviewed changes

verteiger closed this May 17, 2026

verteiger reopened this May 17, 2026

Fixed requested changes.

56344c0

		docker pull verteiger/todoapp:latest

		2. Run the container, mapping the container port 8080 to a host port (example uses host port 8000):

		docker build -t verteiger/todoapp:latest .

		2. Run the locally-built image:

		docker tag verteiger/todoapp:latest verteiger/todoapp:latest

		3. Push:

Conversation

verteiger commented May 17, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

verteiger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

verteiger commented May 17, 2026

Uh oh!

verteiger commented May 17, 2026

Uh oh!

Reviewers

Assignees

Labels