Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support varying primary key fields within a shared index #1

Open
masukomi opened this issue Jul 22, 2023 · 0 comments
Open

support varying primary key fields within a shared index #1

masukomi opened this issue Jul 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@masukomi
Copy link
Owner

masukomi commented Jul 22, 2023 •
edited
Loading

Right now ClassMethods.populate_results_from_ids(...) assumes that all of the models that place records in the index use the same primary key.

As this is essentially always going to be :_id it's not a big concern. However, this customization is allowed and thus should be fully supported.

Additionally extract_ordered_ids_from_hits is just being passed a single primary key. It needs to be able to use the right one per class.
@masukomi masukomi added the enhancement New feature or request label Jul 22, 2023
masukomi added a commit that referenced this issue Jul 22, 2023
@masukomi
readme note re primary keys in shared indexes
b259dac 
- all models must use the same primary key
- haven't gotten around to supporting
  different primary keys per model
  within a shared index
- see issue #1
  #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masukomi