Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web scraping for app version from Mac App Store #707

Closed
rgoldberg opened this issue Jan 12, 2025 · 0 comments · Fixed by #708
Closed

Remove web scraping for app version from Mac App Store #707

rgoldberg opened this issue Jan 12, 2025 · 0 comments · Fixed by #708
Assignees
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Milestone

Comments

@rgoldberg
Copy link
Contributor

Remove web scraping for app version from Mac App Store.

In 2021, some code was added to run immediately after each iTunes Search web API lookup (but not after iTunes Search web API searches) to see if the Mac App Store app web page for the found app reports a newer version of the app than did the iTunes Search web API, because that sometimes listed a newer version faster than the iTunes Search web API.

It uses a very brittle regex to find the version. The regex doesn't work on the one app page I looked at. Getting it to work without possibly returning versions for platforms other than macOS will be hard, and it will massively complicate providing raw JSON in my output overhaul (#190 & #626). It also slows down multiple commands.

The Mac App Store seems to work on eventual consistency. mas now uses the iTunes Search web API queries that I found to return the most up-to-date version info when I tested it a few months ago. They still might be slower (or might be the same or faster) than the Mac App Store app web page, but I don't think that we should complicate things, provide one more source of inconsistency, slow performance, or use a massively error-prone, brittle source of info for anything, let alone something as foundational to mas as app versions. It will also be even more complex if mas supports iOS & iPadOS apps.

Therefore I am removing the code.

@rgoldberg rgoldberg added the 🧹 cleanup Optimization of (not bug fix for) an existing feature label Jan 12, 2025
@rgoldberg rgoldberg added this to the 1.9.1 milestone Jan 12, 2025
@rgoldberg rgoldberg self-assigned this Jan 12, 2025
rgoldberg added a commit to rgoldberg/mas that referenced this issue Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant