Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] UniGetUI Logs and Package Manager Logs unreadable in dark mode (font is black) #2381

Open
4 tasks done
redactedscribe opened this issue Jul 1, 2024 · 9 comments · May be fixed by #2366
Open
4 tasks done

[BUG] UniGetUI Logs and Package Manager Logs unreadable in dark mode (font is black) #2381

redactedscribe opened this issue Jul 1, 2024 · 9 comments · May be fixed by #2366
Assignees
@marticliment
Labels
bug Something isn't working ready-to-go
Milestone
Bugs

Comments

@redactedscribe
Copy link
Contributor

redactedscribe commented Jul 1, 2024 •
edited
Loading

Please confirm these before moving forward

  • I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
  • I have tested that this issue has not been fixed in the latest (beta or stable) release.
  • I have checked the FAQ section for solutions.
  • This issue is about a bug (if it is not, please use the correct template).

UniGetUI Version

3.1.0 beta 1

Windows version, edition and architecture

Windows 11 Pro

Describe your issue

When the Application theme setting is set to Follow system color scheme, the mentions logs also become dark when dark mode activates. The text is very difficult to read because the main font remains black (unlike the Operations history).

Steps to reproduce the issue

Toggle dark mode on.

UniGetUI Log

-

Package Managers Logs

-

Relevant information

As a side note, perhaps the Application theme setting should be moved from the General preferences section to the User interface preferences section? It seems this UI section is only used to customise double-clicking packages, so maybe not.

Screenshots and videos

UniGetUI Logs:

WingetUI_2024-07-01_21-07-33

Package Manager Logs:

WingetUI_2024-07-01_21-08-30
@redactedscribe redactedscribe added the bug Something isn't working label Jul 1, 2024
@marticliment
Copy link
Owner

This is weird...

Perhaps you have you changed the window theme without restarting UniGetUI? If so, this needs to be fixed

@marticliment marticliment added this to the Bugs milestone Jul 1, 2024
@redactedscribe
Copy link
Contributor Author

Perhaps you have you changed the window theme without restarting UniGetUI?

This is a bug which occurs in some other software too, maybe because of a common framework. And yes restarting usually solves the problem, until the next dark mode toggle. Restarting UniGetUI also "fixed" the issue.

@redactedscribe
Copy link
Contributor Author

@marticliment Unfortunately, this bug still occurs in beta 2. Restarting UniGetUI is required to fix the dark mode log issue.

@marticliment
Copy link
Owner

Is it? I have been able to toggle the app theme and open the logs without any issue...

What happens ig you reload the log?

@marticliment marticliment reopened this Jul 2, 2024
@redactedscribe
Copy link
Contributor Author

Right. I'm not sure if this was the case before, but yes, the log must be toggled. If the theme switches with the log open, the font colours aren't updated. Toggling the log loads the needed font colours. Not a major issue as it's rare to have the log open when the theme switches.

@redactedscribe
Copy link
Contributor Author

The system tray icon also remains the previous theme's colour after the theme switches.

@marticliment
Copy link
Owner

#2366

@redactedscribe
Copy link
Contributor Author

Just to note this somewhere: The title bar minimise, maximise and close buttons also stay white when switching from dark to light.

UniGetUI_2024-07-23_19-03-37

@marticliment
Copy link
Owner

This will be fixed by #2490

@marticliment marticliment linked a pull request Aug 30, 2024 that will close this issue
Update: Adapt tray icon to theme changes #2366
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marticliment marticliment

Labels
bug Something isn't working ready-to-go
Projects
None yet
Milestone
Bugs
Development

Successfully merging a pull request may close this issue.

Update: Adapt tray icon to theme changes HO-COOH/WingetUI
2 participants
@redactedscribe @marticliment