Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Responsive for SignupLoginPage.js and LoginPage.js #94

Open
marleymarl opened this issue Apr 27, 2020 · 4 comments
Open

Fix Responsive for SignupLoginPage.js and LoginPage.js #94

marleymarl opened this issue Apr 27, 2020 · 4 comments

Comments

@marleymarl
Copy link
Owner

Only the right side Col (where the form is) should show up on Mobile.

@BaNazari
Copy link
Collaborator

BaNazari commented Apr 27, 2020

Could be done, but what is the purpose of the empty left part? Will it show something in future? If there would be some data, it can be transferred to the section bellow the login section in mobile.

@marleymarl
Copy link
Owner Author

Yes you are right. In the left side will go marketing information e.g. bullet points to describe benefits of having account. It makes sense to have it appear below the form on mobile.

@BaNazari
Copy link
Collaborator

The color palette is different from website and the app. Are we gonna keep this one?

@marleymarl
Copy link
Owner Author

I'm not sure - it works for now. Once we add the marketing text to the left and also complete the website and dashboard, I think we can do a review of our styleguide and see how to bring it all together. Our style guide as it is was pretty rushed and we didn't do any kind of branding beforehand so we should do that work as a team and then come up with a new color scheme and brand guide according to that. In the meantime we can have some parts that don't match exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants