-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ontario Government + GeoTime #45
Comments
Nothing we can really do, if people put CORS in place for their data we should not look for ways to circumvent (there are ways but there could be legal ramification), what you did is perfect contact the API team and let them know...
That's a nice challenge, will look into it on my end... if you can share your code will be nice!
Yes! this project is 2 days old!!! ...and lots of developers needed too |
Here is the site When we have a lot of markers the way to go is Marker Clustering: |
@heldersepu Thank you for the cluster recommendation! I was able to do marker clustering this morning on the Ontario dataset, you can check it out here: I will provide source code soon! |
... but let me reiterate: there are a lot of duplicates on that data: Looking at google maps: |
I think this is your source code:
That name confirms my suspicions |
@heldersepu Yeah for sure. I understand that these are not exact patient case coordinates. |
@heldersepu I don't think governments would give exact patient data? Wouldn't that be a violation of privacy? |
Join us, we can use your expertise... |
@heldersepu Yes, I'll do that. First I need his email. @watadarkstar I'll reach out on LinkedIn to get that from you. |
@watadarkstar That's why we are building a totally anonymous and private input. |
To get a better sense of what data that GeoTimeline captures see: https://app.geotimeline.com/dataview. |
it does not need to be exact or contain private data. Patient landed from Italy on February 30 on Miami international at 10AM with that others can see if they been in the same route with someone potentially infected |
@marleymarl Cool yeah I understand. My project was more about exploring different visualizations on the Ontario dataset. I found your repository and it was a good starting point for me even though I didn't really need the patient collection part. This repo was useful to me because you had a bunch of the work already setup for me. I know I'm not using this codebase as it was intended to be used but it was helpful even for my use case. |
I still want to explore building a heat map with polygon boundaries. But here is what I have tried so far:
Definitely add me to slack and we can chat more :) Here is my source code (master has clusters, hooks, and the swap of Mapbox version: |
Ye refactoring the code would be a very welcomed addition, there is an issue open for that: I'm gonna close this one since it is not something we have to work on |
Hi @marleymarl 👋
I saw your post on Linkedin and wanted to try my hands at integrating the Confirmed positive cases of COVID19 in Ontario dataset with what you have built.
After a couple hours I was able to integrate Ontario's 2,800 data points into your tool, check it out here:
https://covid-19-map-ontario.netlify.com/
I learned a few things along the way that might be useful to you and your team / volunteers.
I tried to integrate with the Ontario Data API at first but ran into CORS issues. A POST to
https://data.ontario.ca/api/3/action/datastore_search should work but it doesn't due to browser CORS issues. I contacted the Ontario data team to see if they can help as it seems like the API is not accessible by 3rd party websites. For the time being I downloaded the JSON data and stored it statically on the website mentioned above.
There should be 2,800 markers on the map but they do not all appear. I'm guessing this is a limitation of the library Google maps React. Two options worth exploring:
There is a way to do it with Google maps but I haven't tried this yet: https://github.com/istarkov/google-map-thousands-markers
What I did try is using Mapbox and react-map-gl built by Uber: https://5e87a24a03eea30006476635--covid-19-map-ontario.netlify.com/
EDIT: It seems like the dataset is not very accurate and is reporting very rough lats and longs and that might be the reason for not all 2,800 markers showing up
Hope this helps you and your team 😄
The text was updated successfully, but these errors were encountered: