Added support for upper case values parse#10
Open
viniciusls wants to merge 2 commits intomariusc23:masterfrom
viniciusls:master
Open
Added support for upper case values parse#10viniciusls wants to merge 2 commits intomariusc23:masterfrom viniciusls:master
viniciusls wants to merge 2 commits intomariusc23:masterfrom
viniciusls:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
It'd be cool if your lib parse the string value to lower case during the comparison because people can send
TRUEorFALSEvalues or evenTrueorFalse. I thought about saving the.toLowerCase()value in another variable to reuse but I guess it wouldn't be worth creating another var just to reuse in two lines. I also thought about converting0and1(both string and number) to bool, but I understand that the package will not have control on where it should parse it or not (the user may actually need it as a numeric value instead of bool), so I leave it untouched.Thanks!