forked from atom/github
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathissueish-detail-container.test.js
386 lines (300 loc) · 15.1 KB
/
issueish-detail-container.test.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
import React from 'react';
import {shallow} from 'enzyme';
import {QueryRenderer} from 'react-relay';
import IssueishDetailContainer from '../../lib/containers/issueish-detail-container';
import {cloneRepository, buildRepository} from '../helpers';
import {queryBuilder} from '../builder/graphql/query';
import {aggregatedReviewsBuilder} from '../builder/graphql/aggregated-reviews-builder';
import GithubLoginModel from '../../lib/models/github-login-model';
import RefHolder from '../../lib/models/ref-holder';
import {getEndpoint} from '../../lib/models/endpoint';
import {InMemoryStrategy, UNAUTHENTICATED, INSUFFICIENT} from '../../lib/shared/keytar-strategy';
import ObserveModel from '../../lib/views/observe-model';
import IssueishDetailItem from '../../lib/items/issueish-detail-item';
import IssueishDetailController from '../../lib/controllers/issueish-detail-controller';
import AggregatedReviewsContainer from '../../lib/containers/aggregated-reviews-container';
import rootQuery from '../../lib/containers/__generated__/issueishDetailContainerQuery.graphql';
describe('IssueishDetailContainer', function() {
let atomEnv, loginModel, repository;
beforeEach(async function() {
atomEnv = global.buildAtomEnvironment();
loginModel = new GithubLoginModel(InMemoryStrategy);
repository = await buildRepository(await cloneRepository());
});
afterEach(function() {
atomEnv.destroy();
});
function buildApp(override = {}) {
const props = {
endpoint: getEndpoint('github.com'),
owner: 'atom',
repo: 'github',
issueishNumber: 123,
selectedTab: 0,
onTabSelected: () => {},
onOpenFilesTab: () => {},
repository,
loginModel,
workspace: atomEnv.workspace,
commands: atomEnv.commands,
keymaps: atomEnv.keymaps,
tooltips: atomEnv.tooltips,
config: atomEnv.config,
switchToIssueish: () => {},
onTitleChange: () => {},
destroy: () => {},
reportRelayError: () => {},
itemType: IssueishDetailItem,
refEditor: new RefHolder(),
...override,
};
return <IssueishDetailContainer {...props} />;
}
it('renders a spinner while the token is being fetched', async function() {
const wrapper = shallow(buildApp());
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')(null);
const repoData = await tokenWrapper.find(ObserveModel).prop('fetchData')(
tokenWrapper.find(ObserveModel).prop('model'),
);
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(repoData);
// Don't render the GraphQL query before the token is available
assert.isTrue(repoWrapper.exists('LoadingView'));
});
it('renders a login prompt if the user is unauthenticated', function() {
const wrapper = shallow(buildApp());
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: UNAUTHENTICATED});
assert.isTrue(tokenWrapper.exists('GithubLoginView'));
});
it("renders a login prompt if the user's token has insufficient scopes", function() {
const wrapper = shallow(buildApp());
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: INSUFFICIENT});
assert.isTrue(tokenWrapper.exists('GithubLoginView'));
assert.match(tokenWrapper.find('p').text(), /re-authenticate/);
});
it('renders an offline message if the user cannot connect to the Internet', function() {
sinon.spy(loginModel, 'didUpdate');
const wrapper = shallow(buildApp());
const e = new Error('wat');
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: e});
assert.isTrue(tokenWrapper.exists('QueryErrorView'));
tokenWrapper.find('QueryErrorView').prop('retry')();
assert.isTrue(loginModel.didUpdate.called);
});
it('passes the token to the login model on login', async function() {
sinon.stub(loginModel, 'setToken').resolves();
const wrapper = shallow(buildApp({
endpoint: getEndpoint('github.enterprise.horse'),
}));
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: UNAUTHENTICATED});
await tokenWrapper.find('GithubLoginView').prop('onLogin')('4321');
assert.isTrue(loginModel.setToken.calledWith('https://github.enterprise.horse', '4321'));
});
it('passes an existing token from the login model', async function() {
sinon.stub(loginModel, 'getToken').resolves('1234');
const wrapper = shallow(buildApp({
endpoint: getEndpoint('github.enterprise.horse'),
}));
assert.deepEqual(await wrapper.find(ObserveModel).prop('fetchData')(loginModel), {token: '1234'});
});
it('renders a spinner while repository data is being fetched', function() {
const wrapper = shallow(buildApp());
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: '1234'});
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(null);
const props = queryBuilder(rootQuery).build();
const resultWrapper = repoWrapper.find(QueryRenderer).renderProp('render')({
error: null, props, retry: () => {},
});
assert.isTrue(resultWrapper.exists('LoadingView'));
});
it('renders a spinner while the GraphQL query is being performed', async function() {
const wrapper = shallow(buildApp());
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: '1234'});
const repoData = await tokenWrapper.find(ObserveModel).prop('fetchData')(
tokenWrapper.find(ObserveModel).prop('model'),
);
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(repoData);
const resultWrapper = repoWrapper.find(QueryRenderer).renderProp('render')({
error: null, props: null, retry: () => {},
});
assert.isTrue(resultWrapper.exists('LoadingView'));
});
it('renders an error view if the GraphQL query fails', async function() {
const wrapper = shallow(buildApp({
endpoint: getEndpoint('github.enterprise.horse'),
}));
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: '1234'});
const repoData = await tokenWrapper.find(ObserveModel).prop('fetchData')(
tokenWrapper.find(ObserveModel).prop('model'),
);
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(repoData);
const error = new Error('wat');
error.rawStack = error.stack;
const retry = sinon.spy();
const resultWrapper = repoWrapper.find(QueryRenderer).renderProp('render')({
error, props: null, retry,
});
const errorView = resultWrapper.find('QueryErrorView');
assert.strictEqual(errorView.prop('error'), error);
errorView.prop('retry')();
assert.isTrue(retry.called);
sinon.stub(loginModel, 'removeToken').resolves();
await errorView.prop('logout')();
assert.isTrue(loginModel.removeToken.calledWith('https://github.enterprise.horse'));
sinon.stub(loginModel, 'setToken').resolves();
await errorView.prop('login')('1234');
assert.isTrue(loginModel.setToken.calledWith('https://github.enterprise.horse', '1234'));
});
it('renders an IssueishDetailContainer with GraphQL results for an issue', async function() {
const wrapper = shallow(buildApp({
owner: 'smashwilson',
repo: 'pushbot',
issueishNumber: 4000,
}));
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: '1234'});
const repoData = await tokenWrapper.find(ObserveModel).prop('fetchData')(
tokenWrapper.find(ObserveModel).prop('model'),
);
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(repoData);
const variables = repoWrapper.find(QueryRenderer).prop('variables');
assert.strictEqual(variables.repoOwner, 'smashwilson');
assert.strictEqual(variables.repoName, 'pushbot');
assert.strictEqual(variables.issueishNumber, 4000);
const props = queryBuilder(rootQuery)
.repository(r => r.issueish(i => i.beIssue()))
.build();
const resultWrapper = repoWrapper.find(QueryRenderer).renderProp('render')({
error: null, props, retry: () => {},
});
const controller = resultWrapper.find(IssueishDetailController);
// GraphQL query results
assert.strictEqual(controller.prop('repository'), props.repository);
// Null data for aggregated comment threads
assert.isFalse(controller.prop('reviewCommentsLoading'));
assert.strictEqual(controller.prop('reviewCommentsTotalCount'), 0);
assert.strictEqual(controller.prop('reviewCommentsResolvedCount'), 0);
assert.lengthOf(controller.prop('reviewCommentThreads'), 0);
// Requested repository attributes
assert.strictEqual(controller.prop('branches'), repoData.branches);
// The local repository, passed with a different name to not collide with the GraphQL result
assert.strictEqual(controller.prop('localRepository'), repository);
assert.strictEqual(controller.prop('workdirPath'), repository.getWorkingDirectoryPath());
// The GitHub OAuth token
assert.strictEqual(controller.prop('token'), '1234');
});
it('renders an IssueishDetailController while aggregating reviews for a pull request', async function() {
const wrapper = shallow(buildApp({
owner: 'smashwilson',
repo: 'pushbot',
issueishNumber: 4000,
}));
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: '1234'});
const repoData = await tokenWrapper.find(ObserveModel).prop('fetchData')(
tokenWrapper.find(ObserveModel).prop('model'),
);
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(repoData);
const props = queryBuilder(rootQuery)
.repository(r => r.issueish(i => i.bePullRequest()))
.build();
const resultWrapper = repoWrapper.find(QueryRenderer).renderProp('render')({
error: null, props, retry: () => {},
});
const reviews = aggregatedReviewsBuilder().loading(true).build();
assert.strictEqual(resultWrapper.find(AggregatedReviewsContainer).prop('pullRequest'), props.repository.issueish);
const reviewsWrapper = resultWrapper.find(AggregatedReviewsContainer).renderProp('children')(reviews);
const controller = reviewsWrapper.find(IssueishDetailController);
// GraphQL query results
assert.strictEqual(controller.prop('repository'), props.repository);
// Null data for aggregated comment threads
assert.isTrue(controller.prop('reviewCommentsLoading'));
assert.strictEqual(controller.prop('reviewCommentsTotalCount'), 0);
assert.strictEqual(controller.prop('reviewCommentsResolvedCount'), 0);
assert.lengthOf(controller.prop('reviewCommentThreads'), 0);
// Requested repository attributes
assert.strictEqual(controller.prop('branches'), repoData.branches);
// The local repository, passed with a different name to not collide with the GraphQL result
assert.strictEqual(controller.prop('localRepository'), repository);
assert.strictEqual(controller.prop('workdirPath'), repository.getWorkingDirectoryPath());
// The GitHub OAuth token
assert.strictEqual(controller.prop('token'), '1234');
});
it('renders an error view if the review aggregation fails', async function() {
const wrapper = shallow(buildApp({
endpoint: getEndpoint('github.enterprise.horse'),
}));
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: '1234'});
const repoData = await tokenWrapper.find(ObserveModel).prop('fetchData')(
tokenWrapper.find(ObserveModel).prop('model'),
);
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(repoData);
const props = queryBuilder(rootQuery)
.repository(r => r.issueish(i => i.bePullRequest()))
.build();
const retry = sinon.spy();
const resultWrapper = repoWrapper.find(QueryRenderer).renderProp('render')({
error: null, props, retry,
});
const reviews = aggregatedReviewsBuilder()
.addError(new Error("It's not DNS"))
.addError(new Error("There's no way it's DNS"))
.addError(new Error('It was DNS'))
.build();
const reviewsWrapper = resultWrapper.find(AggregatedReviewsContainer).renderProp('children')(reviews);
const errorView = reviewsWrapper.find('ErrorView');
assert.strictEqual(errorView.prop('title'), 'Unable to fetch review comments');
assert.deepEqual(errorView.prop('descriptions'), [
"Error: It's not DNS",
"Error: There's no way it's DNS",
'Error: It was DNS',
]);
errorView.prop('retry')();
assert.isTrue(retry.called);
sinon.stub(loginModel, 'removeToken').resolves();
await errorView.prop('logout')();
assert.isTrue(loginModel.removeToken.calledWith('https://github.enterprise.horse'));
});
it('passes GraphQL query results and aggregated reviews to its IssueishDetailController', async function() {
const wrapper = shallow(buildApp({
owner: 'smashwilson',
repo: 'pushbot',
issueishNumber: 4000,
}));
const tokenWrapper = wrapper.find(ObserveModel).renderProp('children')({token: '1234'});
const repoData = await tokenWrapper.find(ObserveModel).prop('fetchData')(
tokenWrapper.find(ObserveModel).prop('model'),
);
const repoWrapper = tokenWrapper.find(ObserveModel).renderProp('children')(repoData);
const variables = repoWrapper.find(QueryRenderer).prop('variables');
assert.strictEqual(variables.repoOwner, 'smashwilson');
assert.strictEqual(variables.repoName, 'pushbot');
assert.strictEqual(variables.issueishNumber, 4000);
const props = queryBuilder(rootQuery)
.repository(r => r.issueish(i => i.bePullRequest()))
.build();
const resultWrapper = repoWrapper.find(QueryRenderer).renderProp('render')({
error: null, props, retry: () => {},
});
const reviews = aggregatedReviewsBuilder()
.addReviewThread(b => b.thread(t => t.isResolved(true)).addComment())
.addReviewThread(b => b.thread(t => t.isResolved(false)).addComment().addComment())
.addReviewThread(b => b.thread(t => t.isResolved(false)))
.addReviewThread(b => b.thread(t => t.isResolved(false)).addComment())
.addReviewThread(b => b.thread(t => t.isResolved(true)))
.build();
const reviewsWrapper = resultWrapper.find(AggregatedReviewsContainer).renderProp('children')(reviews);
const controller = reviewsWrapper.find(IssueishDetailController);
// GraphQL query results
assert.strictEqual(controller.prop('repository'), props.repository);
// Aggregated comment thread data
assert.isFalse(controller.prop('reviewCommentsLoading'));
assert.strictEqual(controller.prop('reviewCommentsTotalCount'), 3);
assert.strictEqual(controller.prop('reviewCommentsResolvedCount'), 1);
assert.lengthOf(controller.prop('reviewCommentThreads'), 3);
// Requested repository attributes
assert.strictEqual(controller.prop('branches'), repoData.branches);
// The local repository, passed with a different name to not collide with the GraphQL result
assert.strictEqual(controller.prop('localRepository'), repository);
assert.strictEqual(controller.prop('workdirPath'), repository.getWorkingDirectoryPath());
// The GitHub OAuth token
assert.strictEqual(controller.prop('token'), '1234');
});
});