Show more errors on player search

Was previously only showing bungie maintenance
errors, but this was insufficient as it's possible
for the API to be down but not in maintenance mode
(as we saw yesterday). Also, this will allow users
to see when e.g. their network connection is
preventing searches from completing.

My original intention for not showing errors was
to avoid showing messages every single time a user
inputs a bad name as its intuitive that a search
which doesn't result in the button being enabled
did not return results; a message is unneeded.

But really I should have always checked specifically
for the errors we want to avoid and let others
through. So my b.

Author: nathanhosselton

Fabled/Sources/PlayerSearchViewController.swift

@@ -1,6 +1,6 @@
 import UIKit
 import Model
-import PromiseKit
+import PMKFoundation
 
 final class PlayerSearchViewController: DeclarativeViewController, RootPresentationViewControllerDelegate {
   private let playerSearchPlatform = State(initialValue: Platform.all)
@@ -118,8 +118,12 @@ final class PlayerSearchViewController: DeclarativeViewController, RootPresentat
         .done { self.player.binding.emit($0.first) }
         .ensure { self.playerSearchActivityIndicator.stopAnimating() }
         .catch {
-          guard let error = $0 as? Bungie.Error, error == .systemDisabledForMaintenance else { return }
-          self.presentationShouldDisplayAlert(for: error)
+          switch $0 {
+          case let .badStatusCode(code, _, _) as PMKHTTPError where code == 400:
+            break //Ignore failed searches due unexpected character entry
+          default:
+            self.presentationShouldDisplayAlert(for: $0)
+          }
         }
     }