Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add return values to click commands #111

Open
mijamo opened this issue Nov 13, 2020 · 0 comments
Open

Enhancement: add return values to click commands #111

mijamo opened this issue Nov 13, 2020 · 0 comments

Comments

@mijamo
Copy link

mijamo commented Nov 13, 2020

Return values in click do not hurt anything nor doe sit have any impact on regular CLI users. However, this would things much easier to work with if somebody wants to build another Click application on top of this.

My use case is that we will need to upload many small tileset with a similar recipe, so I am writing a script that calls this library to do so. I could use the API directly but I would use some of the nice stuff that has already been built in here (ex: upload progress, validation, conversion of files, error handling etc.). Right now I am able to invoke the commands properly (through ctx.invoke) without issue but I cannot really act on their result because they are only sent through echo and not returned.

If you think it is a good idea I can make a pull request to integrate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant