From 7e7c26f1dfc2728b254668fd840437c321638943 Mon Sep 17 00:00:00 2001 From: Tristen Brown Date: Thu, 30 Jun 2022 15:04:11 -0400 Subject: [PATCH] Drop `src/test-cases-app` (#162) * Drop test-cases-app and move start command to doc generation * Revise documentaion, add to headlog --- CHANGELOG.md | 1 + README.md | 5 +-- package.json | 5 +-- src/test-cases-app/html.js | 14 ------- src/test-cases-app/index.html | 14 ------- src/test-cases-app/index.js | 7 ---- .../test-cases-app-underreact.config.js | 39 ------------------- src/test-cases-app/test-cases-app.js | 13 ------- 8 files changed, 3 insertions(+), 95 deletions(-) delete mode 100644 src/test-cases-app/html.js delete mode 100644 src/test-cases-app/index.html delete mode 100644 src/test-cases-app/index.js delete mode 100644 src/test-cases-app/test-cases-app-underreact.config.js delete mode 100644 src/test-cases-app/test-cases-app.js diff --git a/CHANGELOG.md b/CHANGELOG.md index cbaf5543..d7425726 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ Changelog - `src/components/icon/*` - `src/components/control-wrapper/*` - [feature] Adds React Testing Library to newly ported components +- [internal] Drop `src/test-cases-app` from the development workflow of this project. ## 2.0.0-beta.2 diff --git a/README.md b/README.md index a16d2844..b5577a54 100644 --- a/README.md +++ b/README.md @@ -42,11 +42,8 @@ See [the utils documentation](./src/components/utils/README.md). Here are some commands you'll probably want to use: ```bash -# Start the test-cases app. -npm start - # Start the documentation site. -npm run start-docs +npm start # Start Jest's CLI in watch mode. npx jest --watchAll diff --git a/package.json b/package.json index 297e8c54..0f706cb0 100644 --- a/package.json +++ b/package.json @@ -4,10 +4,7 @@ "description": "UI components for Mapbox projects", "main": "index.js", "scripts": { - "build-component-index": "rtk-index ./src/components ./src/test-cases-app/component-index.js", - "prestart": "npm run build-component-index", - "start": "scripts/build-module-indexes.js && underreact start --config='src/test-cases-app/test-cases-app-underreact.config.js'", - "start-docs": "scripts/build-module-indexes.js && scripts/build-docs-data.js && underreact start --config='src/docs/docs-underreact.config.js'", + "start": "scripts/build-module-indexes.js && scripts/build-docs-data.js && underreact start --config='src/docs/docs-underreact.config.js'", "build-docs": "scripts/build-module-indexes.js && scripts/build-docs-data.js && underreact build --config='src/docs/docs-underreact.config.js'", "serve-static-docs": "underreact serve-static --config='src/docs/docs-underreact.config.js'", "deploy-docs": "npm run build-docs && gh-pages -d src/docs/_site", diff --git a/src/test-cases-app/html.js b/src/test-cases-app/html.js deleted file mode 100644 index 02ae4268..00000000 --- a/src/test-cases-app/html.js +++ /dev/null @@ -1,14 +0,0 @@ -module.exports = ` - - - - Test cases - - - - - - - - -`; diff --git a/src/test-cases-app/index.html b/src/test-cases-app/index.html deleted file mode 100644 index 9af32e0c..00000000 --- a/src/test-cases-app/index.html +++ /dev/null @@ -1,14 +0,0 @@ - - - - Test cases - - - - - - -
- - - diff --git a/src/test-cases-app/index.js b/src/test-cases-app/index.js deleted file mode 100644 index b12b9eb9..00000000 --- a/src/test-cases-app/index.js +++ /dev/null @@ -1,7 +0,0 @@ -import React from 'react'; -import ReactDOM from 'react-dom'; -import TestCasesApp from './test-cases-app'; - -const container = document.createElement('div'); -document.body.appendChild(container); -ReactDOM.render(, container); diff --git a/src/test-cases-app/test-cases-app-underreact.config.js b/src/test-cases-app/test-cases-app-underreact.config.js deleted file mode 100644 index 313e7a82..00000000 --- a/src/test-cases-app/test-cases-app-underreact.config.js +++ /dev/null @@ -1,39 +0,0 @@ -const html = require('./html.js'); -const path = require('path'); - -function excludeTsFromFileLoader(config) { - const fileloader = config.module.rules - .find(obj => obj.oneOf) - .oneOf.find(rule => rule.loader && rule.loader.includes('/file-loader/')); - - // Prevent file-loader from treating`.ts` or `.tsx` files as an asset - fileloader.exclude = [...fileloader.exclude, /\.tsx?$/]; -} - -module.exports = () => { - return { - siteBasePath: '/', // react-test-kitchen does not currently support configurable basepaths - jsEntry: path.resolve(__dirname, './index.js'), - htmlSource: html, - devServerHistoryFallback: true, - webpackConfigTransform: config => { - // Add extensions to support TypeScript. Overriding this configuration - // means adding in the defaults as well. - config.resolve.extensions = ['.js', '.json', '.ts', '.tsx']; - - excludeTsFromFileLoader(config); - - config.module.rules.push({ - test: /\.tsx?$/, - use: { - loader: 'ts-loader', - options: { - configFile: path.resolve(__dirname, '../../tsconfig.json') - } - } - }); - - return config; - } - }; -}; diff --git a/src/test-cases-app/test-cases-app.js b/src/test-cases-app/test-cases-app.js deleted file mode 100644 index 8bbaf1ec..00000000 --- a/src/test-cases-app/test-cases-app.js +++ /dev/null @@ -1,13 +0,0 @@ -import React from 'react'; -import ReactTestKitchen from '@mapbox/react-test-kitchen'; -import componentIndex from './component-index'; // eslint-disable-line - -class TestCasesApp extends React.Component { - render() { - return ( - - ); - } -} - -export default TestCasesApp;