From b6a9b5ddfa7d03c835387eb2e6ce46c2788621a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mehmet=20Mall=C4=B1?= Date: Fri, 8 Nov 2024 12:59:19 +0300 Subject: [PATCH] fix: memory leak caused by storing requestsUnderway indefinitely --- lib/node/node-layer.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/node/node-layer.js b/lib/node/node-layer.js index c9798e7..acfb0c5 100644 --- a/lib/node/node-layer.js +++ b/lib/node/node-layer.js @@ -121,6 +121,7 @@ function nodeSend(request) { type: constants.ERROR_REQUEST_ABORTED }); errored = true; + delete requestsUnderway[request.id]; reject(mapiError); }); @@ -145,6 +146,7 @@ function nodeSend(request) { body: body, statusCode: statusCode }); + delete requestsUnderway[request.id]; reject(mapiError); return; } @@ -155,14 +157,17 @@ function nodeSend(request) { headers: httpsResponse.headers, statusCode: httpsResponse.statusCode }); + delete requestsUnderway[request.id]; resolve(response); } catch (responseError) { + delete requestsUnderway[request.id]; reject(responseError); } }); gotStream.on('error', function(error) { errored = true; + delete requestsUnderway[request.id]; reject(error); }); });